Skip to content

fix: ash postgres subquery usage #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

fix: ash postgres subquery usage #524

merged 1 commit into from
Apr 9, 2025

Conversation

artiom
Copy link
Contributor

@artiom artiom commented Apr 8, 2025

Closes #459

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@artiom
Copy link
Contributor Author

artiom commented Apr 8, 2025

Couldn't find a way how to test that code path. manual relation has unique paths (in ash lib), couldn't figure out how to get to this code snippet with tests. Happy for any feedback.

@artiom artiom force-pushed the fix/ash-postgres-subquery-usage branch from 749f67e to 9dbe9c7 Compare April 8, 2025 17:16
@zachdaniel
Copy link
Contributor

I think for backwards compatibility we need to accept both a query return or an ok/error tuple return.

@artiom artiom force-pushed the fix/ash-postgres-subquery-usage branch 2 times, most recently from 3daf41c to f3f5a69 Compare April 9, 2025 09:17
@artiom
Copy link
Contributor Author

artiom commented Apr 9, 2025

I think for backwards compatibility we need to accept both a query return or an ok/error tuple return.

Added.

@artiom artiom force-pushed the fix/ash-postgres-subquery-usage branch from f3f5a69 to 8c92c01 Compare April 9, 2025 12:37
@artiom artiom force-pushed the fix/ash-postgres-subquery-usage branch from 8c92c01 to 170afdd Compare April 9, 2025 12:38
@artiom artiom mentioned this pull request Apr 9, 2025
Merged
6 tasks
@zachdaniel zachdaniel merged commit 69e610b into ash-project:main Apr 9, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency between documentation and actual ash_postgres_subquery type
2 participants
@artiom @zachdaniel