Skip to content

Commit 75653cb

Browse files
asherikovasherikov
committed
Use visibility attributes to hide stuff instead of making public
1 parent e229ed1 commit 75653cb

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

83 files changed

+261
-301
lines changed

‎cmake/ariles_install_component.cmake

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ if(TARGET_TYPE STREQUAL "SHARED_LIBRARY" OR TARGET_TYPE STREQUAL "STATIC_LIBRARY
2121

2222
target_link_libraries(${TGT_ARILES_VISITOR_LIB} PRIVATE ${ARILES_VISITOR_${ARILES_VISITOR}_LIBS})
2323

24-
set_target_properties(${TGT_ARILES_VISITOR_LIB} PROPERTIES CXX_VISIBILITY_PRESET hidden)
25-
set_target_properties(${TGT_ARILES_VISITOR_LIB} PROPERTIES VISIBILITY_INLINES_HIDDEN YES)
24+
#set_target_properties(${TGT_ARILES_VISITOR_LIB} PROPERTIES CXX_VISIBILITY_PRESET hidden)
25+
#set_target_properties(${TGT_ARILES_VISITOR_LIB} PROPERTIES VISIBILITY_INLINES_HIDDEN YES)
2626
else()
2727
target_link_libraries(${TGT_ARILES_VISITOR_LIB} INTERFACE ${PROJECT_NAME}::core)
2828

‎extra_adapters/better_enums/better_enums.h

+6-6
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace ariles2
1717
namespace read
1818
{
1919
template <class t_Visitor, class t_BetterEnum, class t_Flags>
20-
void ARILES2_VISIBILITY_ATTRIBUTE apply_read(
20+
void apply_read(
2121
t_Visitor &visitor,
2222
t_BetterEnum &entry,
2323
const t_Flags & /*param*/,
@@ -41,7 +41,7 @@ namespace ariles2
4141
namespace write
4242
{
4343
template <class t_Visitor, class t_BetterEnum, class t_Flags>
44-
void ARILES2_VISIBILITY_ATTRIBUTE apply_write(
44+
void apply_write(
4545
t_Visitor &writer,
4646
const t_BetterEnum &entry,
4747
const t_Flags &param,
@@ -63,7 +63,7 @@ namespace ariles2
6363
namespace compare
6464
{
6565
template <class t_Visitor, class t_BetterEnum>
66-
void ARILES2_VISIBILITY_ATTRIBUTE apply_compare(
66+
void apply_compare(
6767
t_Visitor &visitor,
6868
const t_BetterEnum &left,
6969
const t_BetterEnum &right,
@@ -87,7 +87,7 @@ namespace ariles2
8787
namespace defaults
8888
{
8989
template <class t_Visitor, class t_BetterEnum>
90-
void ARILES2_VISIBILITY_ATTRIBUTE apply_defaults(
90+
void apply_defaults(
9191
t_Visitor & /*visitor*/,
9292
t_BetterEnum &entry,
9393
const typename t_Visitor::Parameters & /*param*/,
@@ -113,7 +113,7 @@ namespace ariles2
113113
namespace copyfrom
114114
{
115115
template <class t_Visitor, class t_BetterEnum>
116-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyfrom(
116+
void apply_copyfrom(
117117
t_Visitor & /*visitor*/,
118118
t_BetterEnum &left,
119119
const t_BetterEnum &right,
@@ -133,7 +133,7 @@ namespace ariles2
133133
namespace copyto
134134
{
135135
template <class t_Visitor, class t_BetterEnum>
136-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyto(
136+
void apply_copyto(
137137
t_Visitor & /*visitor*/,
138138
const t_BetterEnum &left,
139139
t_BetterEnum &right,

‎extra_adapters/eigen/eigen.h

+16-19
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ namespace ariles2
2020
namespace read
2121
{
2222
template <class t_Visitor, typename t_Scalar, int t_rows, int t_flags>
23-
void ARILES2_VISIBILITY_ATTRIBUTE apply_read(
23+
void apply_read(
2424
t_Visitor &visitor,
2525
Eigen::Matrix<t_Scalar, t_rows, 1, t_flags> &entry,
2626
const typename t_Visitor::Parameters &param)
@@ -47,7 +47,7 @@ namespace ariles2
4747

4848

4949
template <class t_Visitor, typename t_Scalar, int t_rows, int t_cols, int t_flags>
50-
void ARILES2_VISIBILITY_ATTRIBUTE apply_read(
50+
void apply_read(
5151
t_Visitor &visitor,
5252
Eigen::Matrix<t_Scalar, t_rows, t_cols, t_flags> &entry,
5353
const typename t_Visitor::Parameters &parameters)
@@ -83,7 +83,7 @@ namespace ariles2
8383

8484

8585
template <class t_Visitor, typename t_Scalar, int t_dim, int t_mode, int t_options>
86-
void ARILES2_VISIBILITY_ATTRIBUTE apply_read(
86+
void apply_read(
8787
t_Visitor &visitor,
8888
Eigen::Transform<t_Scalar, t_dim, t_mode, t_options> &entry,
8989
const typename t_Visitor::Parameters &param)
@@ -100,7 +100,7 @@ namespace ariles2
100100

101101

102102
template <class t_Visitor, typename t_Scalar, int t_options>
103-
void ARILES2_VISIBILITY_ATTRIBUTE apply_read(
103+
void apply_read(
104104
t_Visitor &visitor,
105105
Eigen::Quaternion<t_Scalar, t_options> &entry,
106106
const typename t_Visitor::Parameters &parameters)
@@ -126,7 +126,7 @@ namespace ariles2
126126
namespace write
127127
{
128128
template <class t_Visitor, typename t_Scalar, int t_rows, int t_flags>
129-
void ARILES2_VISIBILITY_ATTRIBUTE apply_write(
129+
void apply_write(
130130
t_Visitor &writer,
131131
const Eigen::Matrix<t_Scalar, t_rows, 1, t_flags> &entry,
132132
const typename t_Visitor::Parameters &param)
@@ -142,7 +142,7 @@ namespace ariles2
142142

143143

144144
template <class t_Visitor, typename t_Scalar, int t_rows, int t_cols, int t_flags>
145-
void ARILES2_VISIBILITY_ATTRIBUTE apply_write(
145+
void apply_write(
146146
t_Visitor &writer,
147147
const Eigen::Matrix<t_Scalar, t_rows, t_cols, t_flags> &entry,
148148
const typename t_Visitor::Parameters &param)
@@ -166,7 +166,7 @@ namespace ariles2
166166

167167

168168
template <class t_Visitor, typename t_Scalar, int t_dim, int t_mode, int t_options>
169-
void ARILES2_VISIBILITY_ATTRIBUTE apply_write(
169+
void apply_write(
170170
t_Visitor &writer,
171171
const Eigen::Transform<t_Scalar, t_dim, t_mode, t_options> &entry,
172172
const typename t_Visitor::Parameters &param)
@@ -177,10 +177,7 @@ namespace ariles2
177177

178178

179179
template <class t_Visitor, typename t_Scalar, int t_options, class t_Flags>
180-
void ARILES2_VISIBILITY_ATTRIBUTE apply_write(
181-
t_Visitor &writer,
182-
const Eigen::Quaternion<t_Scalar, t_options> &entry,
183-
const t_Flags &param)
180+
void apply_write(t_Visitor &writer, const Eigen::Quaternion<t_Scalar, t_options> &entry, const t_Flags &param)
184181
{
185182
CPPUT_TRACE_FUNCTION;
186183

@@ -203,7 +200,7 @@ namespace ariles2
203200
namespace compare
204201
{
205202
template <class t_Visitor, typename t_Scalar, int t_dim, int t_mode, int t_options>
206-
void ARILES2_VISIBILITY_ATTRIBUTE apply_compare(
203+
void apply_compare(
207204
t_Visitor &visitor,
208205
const Eigen::Transform<t_Scalar, t_dim, t_mode, t_options> &left,
209206
const Eigen::Transform<t_Scalar, t_dim, t_mode, t_options> &right,
@@ -215,7 +212,7 @@ namespace ariles2
215212

216213

217214
template <class t_Visitor, typename t_Scalar, int t_options>
218-
void ARILES2_VISIBILITY_ATTRIBUTE apply_compare(
215+
void apply_compare(
219216
t_Visitor &visitor,
220217
const Eigen::Quaternion<t_Scalar, t_options> &left,
221218
const Eigen::Quaternion<t_Scalar, t_options> &right,
@@ -227,7 +224,7 @@ namespace ariles2
227224

228225

229226
template <class t_Visitor, typename t_Scalar, int t_rows, int t_cols, int t_flags>
230-
void ARILES2_VISIBILITY_ATTRIBUTE apply_compare(
227+
void apply_compare(
231228
t_Visitor &visitor,
232229
const Eigen::Matrix<t_Scalar, t_rows, t_cols, t_flags> &left,
233230
const Eigen::Matrix<t_Scalar, t_rows, t_cols, t_flags> &right,
@@ -246,7 +243,7 @@ namespace ariles2
246243
namespace defaults
247244
{
248245
template <class t_Visitor, typename t_Scalar, int t_rows, int t_cols, int t_flags>
249-
void ARILES2_VISIBILITY_ATTRIBUTE apply_defaults(
246+
void apply_defaults(
250247
const t_Visitor & /*visitor*/,
251248
Eigen::Matrix<t_Scalar, t_rows, t_cols, t_flags> &entry,
252249
const typename t_Visitor::Parameters &param)
@@ -278,7 +275,7 @@ namespace ariles2
278275

279276

280277
template <class t_Visitor, typename t_Scalar, int t_dim, int t_mode, int t_options>
281-
void ARILES2_VISIBILITY_ATTRIBUTE apply_defaults(
278+
void apply_defaults(
282279
const t_Visitor & /*visitor*/,
283280
Eigen::Transform<t_Scalar, t_dim, t_mode, t_options> &entry,
284281
const typename t_Visitor::Parameters & /*param*/)
@@ -289,7 +286,7 @@ namespace ariles2
289286

290287

291288
template <class t_Visitor, typename t_Scalar, int t_options>
292-
void ARILES2_VISIBILITY_ATTRIBUTE apply_defaults(
289+
void apply_defaults(
293290
const t_Visitor & /*visitor*/,
294291
Eigen::Quaternion<t_Scalar, t_options> &entry,
295292
const typename t_Visitor::Parameters & /*param*/)
@@ -306,7 +303,7 @@ namespace ariles2
306303
namespace copyfrom
307304
{
308305
template <class t_Visitor, class t_Left, class t_Right>
309-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyfrom(
306+
void apply_copyfrom(
310307
t_Visitor & /*visitor*/,
311308
t_Left &left,
312309
const t_Right &right,
@@ -323,7 +320,7 @@ namespace ariles2
323320
namespace copyto
324321
{
325322
template <class t_Visitor, class t_Left, class t_Right>
326-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyto(
323+
void apply_copyto(
327324
t_Visitor & /*visitor*/,
328325
const t_Left &left,
329326
t_Right &right,

‎extra_adapters/rosmsg/rosmsg_geometry_msgs.h

+9-9
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ namespace ariles2
1818
namespace copyfrom
1919
{
2020
template <class t_Visitor, typename t_Scalar, int t_flags>
21-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyfrom(
21+
void apply_copyfrom(
2222
t_Visitor & /*visitor*/,
2323
Eigen::Matrix<t_Scalar, 3, 1, t_flags> &left,
2424
const geometry_msgs::Vector3 &right,
@@ -31,7 +31,7 @@ namespace ariles2
3131
}
3232

3333
template <class t_Visitor, typename t_Scalar, int t_flags>
34-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyfrom(
34+
void apply_copyfrom(
3535
t_Visitor & /*visitor*/,
3636
Eigen::Matrix<t_Scalar, Eigen::Dynamic, 1, t_flags> &left,
3737
const geometry_msgs::Vector3 &right,
@@ -46,7 +46,7 @@ namespace ariles2
4646

4747

4848
template <class t_Visitor, typename t_Scalar, int t_options>
49-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyfrom(
49+
void apply_copyfrom(
5050
const t_Visitor & /*visitor*/,
5151
Eigen::Quaternion<t_Scalar, t_options> &left,
5252
const geometry_msgs::Quaternion &right,
@@ -61,7 +61,7 @@ namespace ariles2
6161

6262

6363
template <class t_Visitor, typename t_Scalar, int t_mode, int t_options>
64-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyfrom(
64+
void apply_copyfrom(
6565
const t_Visitor &visitor,
6666
Eigen::Transform<t_Scalar, 3, t_mode, t_options> &left,
6767
const geometry_msgs::Transform &right,
@@ -85,7 +85,7 @@ namespace ariles2
8585
namespace copyto
8686
{
8787
template <class t_Visitor, typename t_Scalar, int t_flags>
88-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyto(
88+
void apply_copyto(
8989
t_Visitor & /*visitor*/,
9090
const Eigen::Matrix<t_Scalar, 3, 1, t_flags> &left,
9191
geometry_msgs::Vector3 &right,
@@ -98,7 +98,7 @@ namespace ariles2
9898
}
9999

100100
template <class t_Visitor, typename t_XprType, bool t_InnerPanel>
101-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyto(
101+
void apply_copyto(
102102
t_Visitor & /*visitor*/,
103103
const Eigen::Block<t_XprType, 3, 1, t_InnerPanel> &left,
104104
geometry_msgs::Vector3 &right,
@@ -111,7 +111,7 @@ namespace ariles2
111111
}
112112

113113
template <class t_Visitor, typename t_Scalar, int t_flags>
114-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyto(
114+
void apply_copyto(
115115
t_Visitor & /*visitor*/,
116116
const Eigen::Matrix<t_Scalar, Eigen::Dynamic, 1, t_flags> &left,
117117
geometry_msgs::Vector3 &right,
@@ -126,7 +126,7 @@ namespace ariles2
126126

127127

128128
template <class t_Visitor, typename t_Scalar, int t_options>
129-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyto(
129+
void apply_copyto(
130130
const t_Visitor & /*visitor*/,
131131
const Eigen::Quaternion<t_Scalar, t_options> &left,
132132
geometry_msgs::Quaternion &right,
@@ -141,7 +141,7 @@ namespace ariles2
141141

142142

143143
template <class t_Visitor, typename t_Scalar, int t_mode, int t_options>
144-
void ARILES2_VISIBILITY_ATTRIBUTE apply_copyto(
144+
void apply_copyto(
145145
const t_Visitor &visitor,
146146
const Eigen::Transform<t_Scalar, 3, t_mode, t_options> &left,
147147
geometry_msgs::Transform &right,

‎extra_visitors/graphviz/ariles2/visitors/graphviz.h

+6-7
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@ namespace ariles2
3434
{
3535
namespace impl
3636
{
37-
class ARILES2_VISIBILITY_ATTRIBUTE Visitor;
37+
class Visitor;
3838
}
3939

4040

41-
class ARILES2_VISIBILITY_ATTRIBUTE Parameters : public write::Parameters
41+
class Parameters : public write::Parameters
4242
{
4343
public:
44-
class ARILES2_VISIBILITY_ATTRIBUTE NodeOptions
44+
class NodeOptions
4545
{
4646
public:
4747
std::string id_;
@@ -104,8 +104,7 @@ namespace ariles2
104104
};
105105

106106

107-
class ARILES2_VISIBILITY_ATTRIBUTE Visitor
108-
: public serialization::PIMPLVisitor<write::VisitorBase<Visitor, Parameters>, impl::Visitor>
107+
class Visitor : public serialization::PIMPLVisitor<write::VisitorBase<Visitor, Parameters>, impl::Visitor>
109108
{
110109
protected:
111110
void startMap(const Parameters &, const Parameters::NodeOptions &);
@@ -150,7 +149,7 @@ namespace ariles2
150149
};
151150

152151

153-
class ARILES2_VISIBILITY_ATTRIBUTE Base : public entry::ConstBase<Visitor>
152+
class Base : public entry::ConstBase<Visitor>
154153
{
155154
};
156155

@@ -183,7 +182,7 @@ namespace ariles2
183182
* @brief Graphviz visitor.
184183
* @ingroup graphviz
185184
*/
186-
struct ARILES2_VISIBILITY_ATTRIBUTE graphviz
185+
struct graphviz
187186
{
188187
using Parameters = ns_graphviz::Parameters;
189188
using Visitor = ns_graphviz::Visitor;

‎extra_visitors/graphviz/src/writer.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,7 @@ namespace ariles2
7171
{
7272
namespace impl
7373
{
74-
class ARILES2_VISIBILITY_ATTRIBUTE Visitor : public serialization::NodeStackBase<NodeWrapper>,
75-
public write::FileVisitorImplementation
74+
class Visitor : public serialization::NodeStackBase<NodeWrapper>, public write::FileVisitorImplementation
7675
{
7776
public:
7877
std::set<std::string> all_ids_;

‎extra_visitors/jsonnet/ariles2/visitors/jsonnet.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ namespace ariles2
3232
* @ingroup jsonnet
3333
*/
3434
template <class t_ParentVisitor>
35-
struct ARILES2_VISIBILITY_ATTRIBUTE jsonnet
35+
struct jsonnet
3636
{
3737
using Reader = ariles2::cfgread::Visitor<ns_jsonnet::Reader<typename t_ParentVisitor::ReaderBase>>;
3838
using Writer = ariles2::cfgwrite::Visitor<typename t_ParentVisitor::WriterBase>;

‎extra_visitors/jsonnet/ariles2/visitors/jsonnet/reader.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ namespace ariles2
1717
{
1818
namespace impl
1919
{
20-
class ARILES2_VISIBILITY_ATTRIBUTE JsonnetPreprocessor;
20+
class JsonnetPreprocessor;
2121

22-
class ARILES2_VISIBILITY_ATTRIBUTE Reader
22+
class Reader
2323
{
2424
protected:
2525
using JsonnetPreprocessorPtr = std::shared_ptr<JsonnetPreprocessor>;
@@ -40,7 +40,7 @@ namespace ariles2
4040

4141

4242
template <class t_ParentVisitor>
43-
class ARILES2_VISIBILITY_ATTRIBUTE Reader : public t_ParentVisitor
43+
class Reader : public t_ParentVisitor
4444
{
4545
protected:
4646
impl::Reader impl_;

‎extra_visitors/jsonnet/src/reader.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace ariles2
2121
{
2222
namespace impl
2323
{
24-
class ARILES2_VISIBILITY_ATTRIBUTE JsonnetPreprocessor
24+
class JsonnetPreprocessor
2525
{
2626
public:
2727
JsonnetVm *vm_;

0 commit comments

Comments
 (0)