fix(test): stabilize tmux-backed test suites#551
Open
johnrichardrinehart wants to merge 1 commit intoasheshgoplani:mainfrom
Open
fix(test): stabilize tmux-backed test suites#551johnrichardrinehart wants to merge 1 commit intoasheshgoplani:mainfrom
johnrichardrinehart wants to merge 1 commit intoasheshgoplani:mainfrom
Conversation
Several test packages were reading the developer's real ~/.agent-deck state, reusing fixed tmux fixture names, and assuming classic shell prompts and a single quit path. That made go test ./... fail nondeterministically depending on local config, shell theme, and leftover tmux sessions. This change gives the tmux/session/integration/UI/TUI tests a temporary HOME, restores shell-friendly non-sandbox startup, broadens shell prompt detection, uses unique control-pipe fixture sessions, and makes the smoke tests tolerant of confirmation and remain-on-exit behavior. Constraint: tmux-backed tests must remain runnable on machines with custom prompts and existing ~/.agent-deck state Rejected: Skip the tmux smoke/integration tests by default | would hide real regressions in the main test path Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep package TestMain isolation in place for any test suite that touches tmux, HOME, or ~/.agent-deck state Tested: go test ./... in the working tree with the same test-fix diff applied; focused reruns for internal/tmux, internal/session, internal/integration, internal/ui, and internal/tuitest Not-tested: clean-worktree full go test ./... under disk-full conditions (verification there hit no-space errors unrelated to code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.agent-deckstateTesting
go test ./...passed in the working tree with this test-fix diff applied./internal/tmux,./internal/session,./internal/integration,./internal/ui, and./internal/tuitest