🌳 Feature - Ability to unsubscribe from a channel #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askmike
reviewed
Sep 14, 2022
| doneHook: false, | ||
| done: false, | ||
| } | ||
| this.subscriptions = this.subscriptions.map((s) => s.id !== sub.id) |
There was a problem hiding this comment.
you mean filter? this will return an array of bools
There was a problem hiding this comment.
Ah yes I did mean filter. will update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to unsubscribe from a channel, it works but it's not very good, I welcome feedback. Ideally It only tries to unsubscribe once which right now it tries over and over. I have copied your pattern, but its not very dry now.