allow ejecting from coverage reporting in jest_config_template.mjs #294
+23
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the ability to let users define their own coverage reporting logic in unique cases. For us, we use monocart-coverage-reporter. In doing so, we needed to write our own `globalTeardown` for jest that uses the split coverage logic, but also manipulates the dat files before they are passed to bazel
gregmagolan
reviewed
Sep 26, 2024
| * also manipulating/massaging the `.dat` file before it gets | ||
| * passed to Bazel | ||
| */ | ||
| if (process.env.SKIP_SETTING_COVERAGE_DIR != "1") { |
There was a problem hiding this comment.
SKIP_SETTING_COVERAGE_DIR is a custom env var that you set on your jest_test targets?
Perhaps we expose this as a config attribute such as automatic_coverage_reporting which default to True but can be opted out of if you roll your own in a globalTeardown?
There was a problem hiding this comment.
Yes because we source our jest_test from a macro that embeds that in env and then give everyone the same baseline jest.config that we provide which has globalTeardown set. I'm fine with a config attribute, but maybe scope it to be rules_jest_automatic_coverage_reporting so it's not so generic it could have other implications
Aghassi
added a commit
to Aghassi/rules_jest
that referenced
this pull request
Jun 13, 2025
Attempts to solve aspect-build#294 through a rule attribute instead of an ENV variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the ability to let users define their own coverage reporting logic in unique cases. For us, we use monocart-coverage-reporter. In doing so, we needed to write our own
globalTeardownfor jest that uses the split coverage logic, but also manipulates the dat files before they are passed to bazel