Skip to content

Conversation

sallustfire
Copy link
Contributor

Added tests exercised by CI to demonstrate eslint usage of tsconfig.json.

#602 (review)


Changes are visible to end-users: no

Copy link

aspect-workflows bot commented Sep 12, 2025

Test

All tests were cache hits

4 tests (100.0%) were fully cached saving 2s.


Test

docs

All tests were cache hits

15 tests (100.0%) were fully cached saving 672ms.


Test

example

7 test targets passed

Targets
//tools/format:format_test_JavaScript_with_prettier [k8-fastbuild]12s
//tools/format:format_test_Markdown_with_prettier [k8-fastbuild]2s
//tools/format:format_test_Protocol_Buffer_with_buf [k8-fastbuild]839ms
//tools/format:format_test_Python_with_ruff [k8-fastbuild]493ms
//tools/format:format_test_SQL_with_prettier [k8-fastbuild]1s
//tools/format:format_test_Scala_with_scalafmt [k8-fastbuild]3s
//tools/format:format_test_Starlark_with_buildifier [k8-fastbuild]196ms

Total test execution time was 19s. 27 tests (79.4%) were fully cached saving 7s.


Test (WORKSPACE) (Test)

example

7 test targets passed

Targets
//tools/format:format_test_JavaScript_with_prettier [k8-fastbuild]12s
//tools/format:format_test_Markdown_with_prettier [k8-fastbuild]1s
//tools/format:format_test_Protocol_Buffer_with_buf [k8-fastbuild]1s
//tools/format:format_test_Python_with_ruff [k8-fastbuild]209ms
//tools/format:format_test_SQL_with_prettier [k8-fastbuild]1s
//tools/format:format_test_Scala_with_scalafmt [k8-fastbuild]7s
//tools/format:format_test_Starlark_with_buildifier [k8-fastbuild]214ms

Total test execution time was 23s. 11 tests (61.1%) were fully cached saving 8s.


Lint [.]      Lint [docs]      Lint [example]

@sallustfire
Copy link
Contributor Author

sallustfire commented Sep 12, 2025

@alexeagle I was debugging support for the tsconfig transitive closure in eslint. Turned out my problem was a typescript import resolver error in the eslint tooling and not rules_lint. However, I thought you might like to have a load bearing test for the tsconfig functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant