Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix db error in assets table, docker fixes for production #154

Merged
merged 5 commits into from
Feb 1, 2025

Conversation

chuckadams
Copy link
Contributor

Pull Request

What changed?

  • Adds a default of 'wp_org' for the repository field on Asset. The new DB schema adds this as a column default so it won't be necessary in the model, but til that's merged, this will fix download issues.
  • The .env file is no longer included in the container image. It was doing things like setting APP_DEBUG to true because it's always a copy of the local dev machine's .env file, and there is no entry in the values+configmap to set it in the real environment (that will be fixed separately)
  • Disables telescope by default in the config. This crappy default is on the telescope devs for delivering that way, but I guess they got too many support requests from drooling morons who never changed the defaults -- as opposed to this drooling moron who also didn't change the default.
  • Adds vim to the container images, which is not really great practice, but useful for on-the-spot debugging during the beta period. There is no sudo in the image (and it wouldn't work on the k8s cluster anyway) so it can't really do much damage.

Why did it change?

Fixes the download issue in all environments, and improves security and performance for prod.

Did you fix any specific issues?

none. h/t to @costdev for the bug reports.

CERTIFICATION

By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.

@chuckadams chuckadams requested a review from costdev February 1, 2025 16:03
@chuckadams
Copy link
Contributor Author

cowboying this PR as usual, since I want prod to stop falling over for the AU testers

@chuckadams chuckadams merged commit 61005cd into main Feb 1, 2025
1 check passed
@chuckadams chuckadams deleted the chuck/fix/attributes-and-prod-settings branch February 1, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant