-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chuck/dev/reset schema #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is considered best practice in postgres, as there is absolutely no difference between text and varchar. if a column size limit is critical, the constraint should be added separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What changed?
make init
, which means you'll need to regenerate API keys (I'll back up and restore the users and tokens on prod to minimize disruption)ac_raw_metadata
are removed, attributes have been added to Plugin and Theme to make the former columns computed from the raw column. This should be transparent to most uses.Why did it change?
The meandering saga of our database migrations includes the AspireSync tables and various missteps and corrections. I'd like something I can easily search with my IDE without the results being full of red herrings.
Normalizing the tables to use the computed attributes makes things like PluginProps and ThemeProps smaller and simpler. It does remove the ability to declare every last bit of plugin state in the constructor, but we can still parse metadata the same way as before.
Did you fix any specific issues?
closes: #125
closes: #126
CERTIFICATION
By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.