Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine asset content-type from extension #163

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

chuckadams
Copy link
Contributor

@chuckadams chuckadams commented Feb 12, 2025

Pull Request

What changed?

  • Uses the file extension in assets to determine their content type instead of hardwiring application/octet-stream
  • Underscores are now allowed in download slug patterns.

Unrelated changes

  • error_reporting(E_ALL & ~E_DEPRECATED) is now enabled in ApplicationServiceProvider unless specifically overridden in config to remain at E_ALL. Laravel and Symfony both insist on spamming stderr with deprecations I can't do anything about until packages update. No more of that nonsense.

  • new bin/dbsh script to get a postgres prompt based on the DB_* variables in .env. Unlike php artisan db this takes arbitrary psql cli arguments, and it's much faster to start.

Why did it change?

Images in browsers are broken without the proper content type. The other things are just necessary gardening.

Did you fix any specific issues?

Closes: #150

CERTIFICATION

By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.

@chuckadams chuckadams requested review from costdev and a team February 12, 2025 17:03
@chuckadams chuckadams merged commit 1fa094e into main Feb 12, 2025
1 check passed
@chuckadams chuckadams deleted the chuck/ac-150/fix-asset-types branch February 12, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download assets are always application/octet-stream
2 participants