Use AppId from config and use GetDeterministicHashCode #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pId if not present
…se that instead of GetHashCode.
|
Thank you for this, I was pulling my hair out trying to find where the AppId was gettting appended from. Any chance for getting this merged anytime soon? |
|
I've created a new PR from your deterministic hash code commit - #114. As to the ability to set AppId via config... it's been discussed before. The short answer is that doing so probably works, but was never the intent, nor something this provider was designed - or more importantly, tested - for. Configurable AppId is a door we would prefer not to open. (Although it is only a screen door, which should be fairly easy to break through if you are determined.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96