Micro-optimization: faster split_selfies#137
Open
rhjohnstone wants to merge 4 commits intoaspuru-guzik-group:masterfrom
Open
Micro-optimization: faster split_selfies#137rhjohnstone wants to merge 4 commits intoaspuru-guzik-group:masterfrom
rhjohnstone wants to merge 4 commits intoaspuru-guzik-group:masterfrom
Conversation
Collaborator
|
Thank you. Give us some time to check and comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just for fun, I implemented
sf.split_selfiesslightly differently, which is 2--4x faster on the selfies I tested. These are valuable microseconds we're saving!All tox tests pass, and I added a new test to confirm correctness and benchmarks comparing the two split methods against 3 different datasets: a list of regular selfies, a list of selfies containing a dot, and a list of much longer selfies. Here are the benchmarks from the 3.10 tests, and they all look like this: