Ci ghcr migration 15756177157947667489#1606
Open
TheSpaceGod wants to merge 3 commits intoassafelovic:mainfrom
Open
Ci ghcr migration 15756177157947667489#1606TheSpaceGod wants to merge 3 commits intoassafelovic:mainfrom
TheSpaceGod wants to merge 3 commits intoassafelovic:mainfrom
Conversation
- Removed `.github/workflows/build.yml` to stop blocking ECR pushes in the build pipeline. - Updated `.github/workflows/docker-push.yml` to add SHA tags for commits and a verification job for the root image. - Updated `.github/workflows/deploy.yml` to sync images from GHCR to ECR for manual deployments, preserving AWS functionality for maintainers. - Updated `README.md` with instructions for pulling from GHCR and added a GHCR badge. Co-authored-by: TheSpaceGod <17182063+TheSpaceGod@users.noreply.github.com>
- Removed `.github/workflows/build.yml` to eliminate ECR build pipeline. - Updated `.github/workflows/docker-push.yml` to be the primary build pipeline, adding SHA tagging and verification. - Updated `.github/workflows/deploy.yml` to remove ECR login/sync steps and pass GHCR repository URL to Terraform. - Updated `terraform/main.tf` and `terraform/variables.tf` to support deploying directly from `image_repository` (GHCR) instead of ECR. - Updated `README.md` with GHCR pull instructions and badge. Co-authored-by: TheSpaceGod <17182063+TheSpaceGod@users.noreply.github.com>
- Removed `.github/workflows/build.yml` to eliminate ECR build pipeline failures. - Updated `.github/workflows/docker-push.yml` to be the primary build pipeline. - Added conditional logic to only push to Docker Hub if authenticated. - Disabled image pushing on Pull Requests to prevent 401 Unauthorized errors and separate build verification from artifact publishing. - Added SHA tagging and a verification job for the root image. - Updated `.github/workflows/deploy.yml` to remove ECR login/sync steps and pass GHCR repository URL to Terraform. - Updated `terraform/main.tf` and `terraform/variables.tf` to support deploying directly from `image_repository` (GHCR) instead of ECR. - Updated `README.md` with GHCR pull instructions and badge. Co-authored-by: TheSpaceGod <17182063+TheSpaceGod@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated the Docker image CI/CD pipeline from AWS ECR to GitHub Container Registry (GHCR) to resolve authentication issues and remove external dependencies for public image distribution.
Key changes:
Consolidated Build/Push: The docker-push.yml workflow is now the single source of truth for building and pushing images (to GHCR). Added type=sha tagging to ensure every commit is buildable and deployable.
Removed Blocking Workflow: Deleted build.yml which was causing CI failures due to AWS role assumption issues.
Deployment Sync: Updated deploy.yml to pull the required image from GHCR and push it to ECR during manual deployments. This keeps the deployment logic separate and allows maintainers to deploy specific versions even without the build pipeline pushing to ECR.
Verification: Added a verify-images job to docker-push.yml to ensure images are successfully built and pullable from GHCR.
Documentation: Updated README.md to reflect the move to GHCR.