Fix blocking, add support of argument table #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest version
feat(all): add support for headers with ampq.Table arguments refact(example): refactor basic example to send continuously messages for reconnection testing
|
I'll review this |
| // return from routine to launch reconnect process | ||
| return | ||
| case blocking := <-chanBlocking: | ||
| c.blocking <- blocking |
There was a problem hiding this comment.
this will block forever in case if user is not reading c.blocking, previously it had fallback with default case
case blocking := <-chanBlocking:
select {
case c.blocking <- blocking:
default:
}
}
There was a problem hiding this comment.
Ok sorry, I was wondering what the purpose of the inner select was, it's fixed.
| return | ||
| case blocking := <-chanBlocking: | ||
| select { | ||
| case c.blocking <- blocking: |
There was a problem hiding this comment.
So pushing in a channel that is full inside a select goes to default, is that right ?
|
LGTM, someone from @assembla/developers should merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12 blocking issue
Closes #13 support of header table
Refactor basic example to send messages at fixed rate to be able to test reconnection.