Improve consistency of 'database_retention_policy' and 'database_retention_ttl' values in interface aggregate mappings#77
Merged
shinnokdisengir merged 2 commits intoFeb 2, 2026
Conversation
frossq
force-pushed
the
fix-intf-validation
branch
from
January 30, 2026 16:50
b81f423 to
b381b4d
Compare
shinnokdisengir
self-requested a review
February 2, 2026 08:42
shinnokdisengir
requested changes
Feb 2, 2026
shinnokdisengir
left a comment
shinnokdisengir
left a comment
Collaborator
There was a problem hiding this comment.
the test commit is not verified
| allow_unset <- MappingGenerator.allow_unset(interface_type), | ||
| explicit_timestamp <- MappingGenerator.explicit_timestamp(interface_type) do | ||
| explicit_timestamp <- MappingGenerator.explicit_timestamp(interface_type), | ||
| db_retention_policy <- |
Collaborator
There was a problem hiding this comment.
For variables, it would be more correct to use the same names as the fields, if possible
Contributor
Author
There was a problem hiding this comment.
I did, but got a Credo complain for 'line too long' (> 100 characters); the easiest fix was to abbreviate the variable name. Open to suggestions
frossq
force-pushed
the
fix-intf-validation
branch
from
February 2, 2026 10:00
b381b4d to
a704f00
Compare
frossq
force-pushed
the
fix-intf-validation
branch
from
February 2, 2026 10:26
a704f00 to
06ed2a5
Compare
…pings Signed-off-by: frossq <francesco.asquini@secomind.com>
Signed-off-by: frossq <francesco.asquini@secomind.com>
frossq
force-pushed
the
fix-intf-validation
branch
from
February 2, 2026 10:41
06ed2a5 to
6eb0988
Compare
shinnokdisengir
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align with the astarte_core improved validation of 'database_retention_policy' and 'database_retention_ttl' values to fix astarte-platform/astarte#1072