Conversation
…um - ie. Pass, Fail, skip, broken, error, setup error, teardown error
antsundq
reviewed
Feb 21, 2026
Contributor
antsundq
left a comment
antsundq
left a comment
There was a problem hiding this comment.
Was the relinking because of the dialog you posted in the issue? It would have been better to have this fixed in a different PR as it is very difficult to review. But it will have to do..
What is the *.UserState and why does it need to be in .gitignore?
I might refactor the parameterized test into a regular test. Just to avoid having additional dependencies for the project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pretty sure I've fixed it.
Wrote a few tests. Tests did use the Parameterized Tests, so you'll want to include that in your contributor guidelines as well, or the tests can be rewritten without the parameterization.
A bunch of stuff relinked, so it shows up as changes.
Main changes were to the tests and the API - most anything else can be discarded if it conflicts - it's probably just the relinking.