-
Notifications
You must be signed in to change notification settings - Fork 1.1k
pjsip: Upgrade bundled version to pjproject 2.16 #1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attention! This pull request may contain issues that could prevent it from being accepted. Please review the checklist below and take the recommended action. If you believe any of these are not applicable, just add a comment and let us know.
- The are no
cherry-pick-toheaders in any comment in this PR. If the PR applies to more than just the branch it was submitted against, please add a comment with one or morecherry-pick-to: <branch>headers or a comment withcherry-pick-to: noneto indicate that this PR shouldn't be cherry-picked to any other branch. See the Code Contribution documentation for more information.
Documentation:
|
Workflow PRCheck failed |
|
The os.h patch should be submitted to the upstream project |
|
@seanbright I just have pushed a PR pjsip/pjproject#4695 for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silentindark pjproject 2.16 seems to cause unit test failures and an ASSERT in test_res_rtp.c.
Try running test execute category /res/res_rtp/ locally.
You also have two colons in the commit message: Resolves::
|
Workflow PRCheck failed |
74a826d to
7b34b86
Compare
|
@gtjoseph Two colons in the commit message: Resolves:: -> Resolves: has been fixed. |
|
Workflow PRCheck failed |
7b34b86 to
ecc601d
Compare
The os.h patch merged to the upstream project |
|
Workflow PRCheck failed |
|
I actually get a ABRT because of an assert failure when I run it locally but that may be because of compile option differences (I use --enable-dev-mode). You're on the right track though. If you want to see where the CI run crashed, download https://github.com/asterisk/asterisk/actions/runs/19885178699/artifacts/4747495999 |
UserNote: Bundled pjproject has been upgraded to 2.16. For more information visit pjproject Github page: https://github.com/pjsip/pjproject/releases/tag/2.16 Resolves: asterisk#1612
ecc601d to
373034f
Compare
|
Workflow PRCheck failed |



UserNote: Bundled pjproject has been upgraded to 2.16. For more
information visit pjproject Github page: https://github.com/pjsip/pjproject/releases/tag/2.16
Resolves: #1612