Skip to content

Conversation

@silentindark
Copy link
Contributor

@silentindark silentindark commented Dec 2, 2025

UserNote: Bundled pjproject has been upgraded to 2.16. For more
information visit pjproject Github page: https://github.com/pjsip/pjproject/releases/tag/2.16

Resolves: #1612

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention! This pull request may contain issues that could prevent it from being accepted. Please review the checklist below and take the recommended action. If you believe any of these are not applicable, just add a comment and let us know.

  • The are no cherry-pick-to headers in any comment in this PR. If the PR applies to more than just the branch it was submitted against, please add a comment with one or more cherry-pick-to: <branch> headers or a comment with cherry-pick-to: none to indicate that this PR shouldn't be cherry-picked to any other branch. See the Code Contribution documentation for more information.

Documentation:

@github-actions github-actions bot added the has-pr-checklist A PR Checklist is present on the PR label Dec 2, 2025
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Workflow PRCheck failed
master-unit: runAsteriskUnitTests.sh: Coredumps found after running tests

@silentindark silentindark marked this pull request as draft December 2, 2025 11:38
@seanbright
Copy link
Contributor

The os.h patch should be submitted to the upstream project

@silentindark
Copy link
Contributor Author

silentindark commented Dec 2, 2025

@seanbright I just have pushed a PR pjsip/pjproject#4695 for this.

Copy link
Member

@gtjoseph gtjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silentindark pjproject 2.16 seems to cause unit test failures and an ASSERT in test_res_rtp.c.

Try running test execute category /res/res_rtp/ locally.

You also have two colons in the commit message: Resolves::

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Workflow PRCheck failed
master-unit: runAsteriskUnitTests.sh: Coredumps found after running tests

@silentindark
Copy link
Contributor Author

@gtjoseph Two colons in the commit message: Resolves:: -> Resolves: has been fixed.
I will try to find out a cause of unit test failures and an ASSERT in test_res_rtp.c.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Workflow PRCheck failed
master-unit: runAsteriskUnitTests.sh: Coredumps found after running tests

@silentindark
Copy link
Contributor Author

The os.h patch should be submitted to the upstream project

The os.h patch merged to the upstream project

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Workflow PRCheck failed
master-unit: runAsteriskUnitTests.sh: Coredumps found after running tests

@silentindark
Copy link
Contributor Author

Try running test execute category /res/res_rtp/ locally.

I have tried it locally.
image

Got a Backtraces
image

From file /tmp/core-asterisk-2025-12-03T11-15-06Z-thread1.txt
Looks like that ast_rtp_instance_get_stats is trying to operate on a memory address (0x7fdbe40f5df0) that is no longer a valid.
image

Please correct me if I am wrong.
But still investigating...

@gtjoseph
Copy link
Member

gtjoseph commented Dec 3, 2025

I actually get a ABRT because of an assert failure when I run it locally but that may be because of compile option differences (I use --enable-dev-mode). You're on the right track though.

If you want to see where the CI run crashed, download https://github.com/asterisk/asterisk/actions/runs/19885178699/artifacts/4747495999

UserNote: Bundled pjproject has been upgraded to 2.16. For more
information visit pjproject Github page: https://github.com/pjsip/pjproject/releases/tag/2.16

Resolves: asterisk#1612
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Workflow PRCheck failed
master-unit: FAILED TEST: res/res_rtp/fir_nominal
master-unit: FAILED TEST: res/res_rtp/sr_rr_nominal
master-unit: FAILED TEST: res/res_rtp/remb_nominal
master-unit: FAILED TEST: res/res_rtp/lost_packet_stats_nominal
master-unit: FAILED TEST: res/res_rtp/nack_overflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-pr-checklist A PR Checklist is present on the PR pr-submit-tests-failed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[improvement]: pjsip: Upgrade bundled version to pjproject 2.16

3 participants