Replace yappcap with scapy for packet capture. #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yappcap will never build again because of ancient Cython so it's been replaced with "scapy" which is popular and well maintained. * The extra.txt requirements file was removed as it's no longer needed. * The verify_pidf and verify_xpidf tests needed minor tweaks to make them reliable because the tests ended with the sipp scenarios before the validation could complete. * The callee_local_direct_media and caller_local_direct_media tests indicated that they needed yappcap and pyxb but they actually need neither so those dependencies were removed. The tests still have issues however so they remain skipped. * The codec_opus tests all fail for other reasons but they never get run anyway. Issue opened.
|
cherry-pick-to: 20 |
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
|
Workflow PRCheck completed successfully |
mbradeen
approved these changes
Oct 13, 2025
jcolp
approved these changes
Oct 14, 2025
github-actions
bot
added
cherry-pick-testing-in-progress
|
Workflow PRCPCheck failed |
|
Workflow PRCPCheck completed successfully |
gtjoseph
added
merge-approved
and removed
cherry-pick-checks-failed
github-actions
bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
merge-in-progress
and removed
merge-approved
pre-merge-testing-in-progress
labels
|
Successfully merged to branch master and cherry-picked to ["20","21","22","23","certified/20.7"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yappcap will never build again because of ancient Cython so it's been
replaced with "scapy" which is popular and well maintained.
The extra.txt requirements file was removed as it's no longer needed.
The verify_pidf and verify_xpidf tests needed minor tweaks to make them
reliable because the tests ended with the sipp scenarios before the
validation could complete.
The callee_local_direct_media and caller_local_direct_media tests indicated
that they needed yappcap and pyxb but they actually need neither so those
dependencies were removed. The tests still have issues however so they
remain skipped.
The codec_opus tests all fail for other reasons but they never get run
anyway. Issue opened.