Support body div level style and region#131
Merged
asticode merged 4 commits intoasticode:masterfrom Oct 14, 2025
Merged
Conversation
Contributor
Author
|
ping @asticode for reminding |
asticode
requested changes
Oct 9, 2025
Owner
asticode
left a comment
asticode
left a comment
There was a problem hiding this comment.
Thanks for the PR and sorry for the delayed review ❤️
Owner
|
Thanks for the PR ❤️ Let me know whether you need a tag 👍 |
Contributor
Author
|
@asticode , Yes, I need it, could you do me a favor and create a tag for my project? |
Owner
FYI I've created a |
Contributor
Author
|
Many thanks for that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @asticode ,
Style and region for ttml can be specify in
bodyanddivtoo, please refer to testdata/example-in-style-inheritance.ttml to see the real case. Style/region will be inherited by this orderbody>div>p.Besides, according to TTML standard, when both parent node and child node define style/region, the one in child node will win. Thus, I implement an override mechanism in your TTML parsing step to bring all the style/region from parent node down to the item (
<\p>) node if there is no corresponding attribute in the child node. With that, the "Subtitles" object structure will not be broken and the style/region can be preserved. The side-effect is that the output TTML can be a little bit longer compare to input TTML.