fix missing STL25.01 in GSI block when converting TTML to STL#136
Merged
asticode merged 2 commits intoasticode:masterfrom Jan 16, 2026
Merged
fix missing STL25.01 in GSI block when converting TTML to STL#136asticode merged 2 commits intoasticode:masterfrom
asticode merged 2 commits intoasticode:masterfrom
Conversation
Owner
|
Could you add a small test for this? |
Owner
|
Thanks for the PR! ❤️ Let me know whether you need a tag 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting TTML subtitles to EBU STL format, the disk format code
"STL25.01" was missing from the GSI block (bytes 3-10), appearing as
spaces instead.
Root cause: newGSIBlock() was unconditionally overwriting the default
framerate (25) and displayStandardCode ("1") with values from metadata,
even when those metadata fields were uninitialized (0 or empty string).
Since TTML files typically don't contain framerate metadata, this
resulted in framerate=0, which has no mapping in stlFramerateMapping,
producing an empty disk format code.