-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to pyproject.toml
for specifying package metadata
#173
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
==========================================
+ Coverage 93.10% 93.42% +0.32%
==========================================
Files 29 28 -1
Lines 3146 3135 -11
==========================================
Hits 2929 2929
+ Misses 217 206 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
393ec4d
to
7e94a9d
Compare
This PR is a dependency for #204 and we would ideally also merge before resolving #205 as then we can integrate the formatter configuration directly in to the I've merged in latest changes from |
@matt-graham I had some issues here relating to healpy dropping support for older MacOS versions. I also ran into a version control issue relating to SciPy and healpy, a solution to which was just pinning the SciPy version. This should be fine for now, we'll just need to keep an eye on that in future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Only change was pinning the SciPy version to avoid version conflicts.
Switches from current
setup.py
approach of specifying package metadata to instead use apyproject.toml
configuration file and sets upsetuptools_scm
to automatically set package version number from Git release tags.I think I've directly translated all the arguments passed to
setup
function in previoussetup.py
to equivalentpyproject.toml
properties, so this should retain same metadata when publishing to PyPI, other than there was previously a slight typo in one argument (pacakge_data
instead ofpackage_data
) which is now fixed. I've also added the additional requirements files as optional dependencies which can be installed withpip
using the extras syntax, for examplepip install s2fft[tests]
. I also integrated the previous content inpytest.ini
in to thepyproject.toml
file.