Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test matrix and add scheduled tests #210

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

matt-graham
Copy link
Collaborator

@matt-graham matt-graham commented Sep 16, 2024

Updates test matrix to run tests across all supported Python versions (currently Python 3.8 – 3.12) and operating systems. Also adds weekly scheduled test runs to resolve #208.

Given this makes the test matrix quite large (15 combinations of OS and Python version), and Python 3.8 and Python 3.9 are both out of the recommended support window of both SPEC0 and NEP29, I would also recommend we consider dropping Python 3.8 and Python 3.9 support (in a separate PR).

EDIT: Appears that there are not Windows wheels available for healpy / pyssht and we're getting a segfault somewhere when using MacOS / Python 3.9+ so reverting to only testing on Ubuntu + (MacOS, Python 3.8) for now.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (1254b92) to head (1d195ff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files          29       29           
  Lines        3167     3167           
=======================================
  Hits         2954     2954           
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-graham matt-graham linked an issue Sep 16, 2024 that may be closed by this pull request
@matt-graham matt-graham added the infrastructure Issues related to infrastructure for repository and project label Oct 8, 2024
@matt-graham
Copy link
Collaborator Author

I've merged in main to resolve conflicts from some files also edited in #233 (mainly some manual edits to make docstrings raw here to avoid issues on newer Python versions that Ruff also flagged and fixed). I've also added a path filter to the pull-request trigger here to only run tests workflow when we are updating files which could lead to changes in test behaviour, which should prevent needing to run tests when for example just updating Markdown files or metadata files like all-contributorsrc.

Copy link
Collaborator

@CosmoMatt CosmoMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that we're running into issues with the actions MacOS workers, but we can address this later. In any case, great to set up testing across a variety of architectures, and importantly the nightly tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to infrastructure for repository and project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add weekly tests to catch breaks due to updates in dependencies Issue when import pyssht
2 participants