-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide PyTorch implementations by wrapping JAX functions #277
Draft
matt-graham
wants to merge
21
commits into
main
Choose a base branch
from
mmg/pytorch-wrapper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the current manual reimplementation of the precompute transform and some of the utility functions provided by
s2fft
to allow use with PyTorch in favour of wrapping the JAX implementations using JAX and PyTorch's mutual support for the DLPack standard as outlined by Matt Johnson in this Gist.Some local benchmarking suggests there is no performance degradation with this wrapping approach compared to the 'native' implementations beyond the very smallest bandlimits
L
and a potential a small constant factor speedup for largerL
- see benchmarks results in files belowprecompute-spherical-torch-benchmarks.json
precompute-spherical-torch-wrapper-benchmarks.json
As all imports from
torch
are after changes in this PR confined to thes2fft.utils.torch_wrapper
module and the import there is guarded in antry: ... except ImportError
block this PR also removestorch
from the required dependencies for the project, with an informative error message being raised when the user tries to use the wrapper functionality withouttorch
being installed.Todo
torch_wrapper
modules2fft.utils.quadrature_torch
ands2fft.utils.resampling_torch