Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use libnotmuch config api #757

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use libnotmuch config api #757

wants to merge 4 commits into from

Conversation

jorsn
Copy link
Member

@jorsn jorsn commented Jun 29, 2024

@ibuclaw

  • Thank you for your patch, which is the main part of this!
  • Could you review my little changes? To me the tests looked fine except for the fix in 4bd20ed. Also, they run successfully.

@gauteh Do you have an opinion on this, especially on the tests?

ibuclaw and others added 4 commits June 29, 2024 19:01
@ibuclaw @jorsn
use libnotmuch to read notmuch config
998b848 
This requires libnotmuch >=5.4 (notmuch >= 0.32).

cherry-pick from ibuclaw@a7c8ab5
@jorsn
fix notmuch database tests
4bd20ed
@jorsn
ci: drop Debian bullseye and Ubuntu focal
cf84e3f 
We require libnotmuch >= 5.4 / notmuch >= 0.32,
but bullseye has 0.31.4 and focal has 0.29.3
(see https://repology.org/project/notmuch/versions).
@jorsn
let notmuch search config file if undefined by astroid
717ffcc
@jorsn jorsn mentioned this pull request Jun 29, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use libnotmuch to read notmuch config error: no notmuch config file found.
2 participants
@jorsn @ibuclaw