Skip to content

Fix skymap reading on Windows #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2025
Merged

Fix skymap reading on Windows #571

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81cbeb1
Fix reading skymap windows
camposandro Oct 20, 2025
3a8219d
Use unlink instead of remove
camposandro Oct 20, 2025
a5ec40e
Satisfy pylint
camposandro Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/hats/io/file_io/file_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import os
import tempfile
from collections.abc import Generator
from io import BytesIO
Expand Down Expand Up @@ -255,11 +256,14 @@ def read_fits_image(map_file_pointer: str | Path | UPath) -> np.ndarray:
value at each index corresponds to the number of objects found at the healpix pixel.
"""
map_file_pointer = get_upath(map_file_pointer)
with tempfile.NamedTemporaryFile() as _tmp_file:
with tempfile.NamedTemporaryFile(delete=False) as _tmp_file:
with map_file_pointer.open("rb") as _map_file:
map_data = _map_file.read()
_tmp_file.write(map_data)
return Skymap.from_fits(_tmp_file.name).values
_tmp_file.write(_map_file.read())
tmp_path = _tmp_file.name
try:
return Skymap.from_fits(tmp_path).values
finally:
os.unlink(tmp_path)


def write_fits_image(histogram: np.ndarray, map_file_pointer: str | Path | UPath):
Expand Down