Merge pull request #300 from eerovaher/rm-EarthLocation-get-site-registry

Avoid using the private `EarthLocation._get_site_registry()` in tests

Author: braingram

asdf_astropy/converters/coordinates/tests/test_earth_location.py

@@ -5,8 +5,6 @@
 from astropy.coordinates.earth import ELLIPSOIDS
 from astropy.units import Quantity
 
-from asdf_astropy.testing.helpers import assert_earth_location_equal
-
 
 def create_earth_locations():
     longitude = Longitude([0.0, 45.0, 90.0, 135.0, 180.0, -180, -90, -45], u.deg, wrap_angle=180 * u.deg)
@@ -33,24 +31,3 @@ def test_serialization(earth_location, tmp_path):
 
     with asdf.open(file_path) as af:
         assert (af["earth_location"] == earth_location).all()
-
-
-@pytest.fixture
-def _builtin_site_registry():
-    orig_sites = getattr(EarthLocation, "_site_registry", None)
-    EarthLocation._get_site_registry(force_builtin=True)
-    yield
-    EarthLocation._site_registry = orig_sites
-
-
-@pytest.mark.usefixtures("_builtin_site_registry")
-def test_earthlocation_site(tmp_path):
-    earth_location = EarthLocation.of_site("greenwich")
-
-    file_path = tmp_path / "test.asdf"
-    with asdf.AsdfFile() as af:
-        af["earth_location"] = earth_location
-        af.write_to(file_path)
-
-    with asdf.open(file_path) as af:
-        assert_earth_location_equal(af["earth_location"], earth_location)