Skip to content

feat: add analysis request models and RPC handler for network flow an…#81

Merged
pranjal-astuto merged 1 commit into
mainfrom
OL-6630-Modify-onelens-python-client-to-include-network-flow-request-rpc-call
Mar 2, 2026
Merged

feat: add analysis request models and RPC handler for network flow an…#81
pranjal-astuto merged 1 commit into
mainfrom
OL-6630-Modify-onelens-python-client-to-include-network-flow-request-rpc-call

Conversation

@arifshekh175

Copy link
Copy Markdown
Contributor

…alysis

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the backend client's capabilities by introducing a comprehensive set of models and an RPC handler for managing network flow analysis requests. This enhancement allows for the structured creation, retrieval, and modification of analysis requests, enabling users to define and track network flow analysis tasks with specific parameters like AWS account, region, and date ranges.

Highlights

  • New Data Models for Network Flow Analysis: Introduced several new Pydantic models in onelens_backend_client_v2/models.py to support network flow analysis requests. These include AnalysisRequestStatus, AnalysisRequestMixin, CreateAnalysisRequestAPIRequest, GetAnalysisRequestsAPIRequest, GetAnalysisRequestsRequest, GetAnalysisRequestsResponse, ListFlowLogsAPIRequest, UpdateAnalysisRequestRequest, and UpdateAnalysisRequestResponse.
  • New RPC Handler for Network Flow Analysis: Added a new RPC handler, NetworkFlowAnalysisRequestsServiceRpcHandler, to manage network flow analysis requests. This handler provides functionalities to retrieve and update analysis requests.
  • RPC Handler Integration: Integrated the new NetworkFlowAnalysisRequestsServiceRpcHandler into the main RPC initialization file (onelens_backend_client_v2/rpc/__init__.py), making it accessible within the client.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • onelens_backend_client_v2/models.py
    • Added AnalysisRequestStatus enum to define the lifecycle states of an analysis request.
    • Introduced AnalysisRequestMixin as a base model for common analysis request attributes.
    • Defined CreateAnalysisRequestAPIRequest for initiating new analysis requests.
    • Added GetAnalysisRequestsAPIRequest, GetAnalysisRequestsRequest, and GetAnalysisRequestsResponse for querying analysis requests with filtering and pagination.
    • Included ListFlowLogsAPIRequest for specifying parameters to list flow logs.
    • Created UpdateAnalysisRequestRequest and UpdateAnalysisRequestResponse for modifying existing analysis requests.
  • onelens_backend_client_v2/rpc/init.py
    • Imported NetworkFlowAnalysisRequestsServiceRpcHandler.
    • Added NetworkFlowAnalysisRequestsServiceRpcHandler to the __all__ export list.
  • onelens_backend_client_v2/rpc/network_flow_analysis_requests_service_rpc_handler.py
    • Created NetworkFlowAnalysisRequestsServiceRpcHandler class.
    • Implemented get_analysis_requests method to list analysis requests.
    • Implemented update_analysis_request method to modify analysis request status and metadata.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new Pydantic models and an RPC handler for network flow analysis requests. The changes are generally well-structured. I've provided a few suggestions to improve type safety, reduce code duplication in the models, and clean up imports in the new RPC handler file. These changes will enhance the maintainability and readability of the code.

Comment thread onelens_backend_client_v2/models.py
Comment thread onelens_backend_client_v2/models.py

@pranjal-astuto pranjal-astuto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pranjal-astuto pranjal-astuto merged commit 384d638 into main Mar 2, 2026
0 of 10 checks passed
@arifshekh175 arifshekh175 deleted the OL-6630-Modify-onelens-python-client-to-include-network-flow-request-rpc-call branch March 2, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants