Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate the property type for generated objects #1467

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Generate the property type for generated objects #1467

merged 1 commit into from
Jul 3, 2023

Conversation

stof
Copy link
Member

@stof stof commented Jun 26, 2023

No description provided.

@stof stof force-pushed the result_member_type branch from 5a111c2 to e3b6c96 Compare June 26, 2023 08:42
@stof stof changed the title Generate the property type for result objects Generate the property type for generated objects Jun 26, 2023
@stof stof mentioned this pull request Jun 26, 2023
Merged
@stof
Copy link
Member Author

stof commented Jun 26, 2023

I'll wait for my other PRs to be merged before fixing static analysis issues here, as they will contribute to it.

@stof stof force-pushed the result_member_type branch 4 times, most recently from 2074353 to 739ec63 Compare June 28, 2023 12:18
@stof stof mentioned this pull request Jun 28, 2023
Merged
@stof stof force-pushed the result_member_type branch from 739ec63 to d3b719d Compare June 28, 2023 13:13
@stof stof mentioned this pull request Jun 29, 2023
Open
@stof stof force-pushed the result_member_type branch from d3b719d to df1b861 Compare July 1, 2023 20:50
@stof stof force-pushed the result_member_type branch from df1b861 to d53f481 Compare July 1, 2023 21:24
@stof
Copy link
Member Author

stof commented Jul 1, 2023

For the 3 new errors added in the psalm baseline due to having types for properties, 1 would be fixed by #1489 and the other 2 are related to #1481 (for the part I haven't fixed yet). I used to have many more reports before my other PRs related to #1481.

@stof stof requested a review from jderusse July 2, 2023 06:32
@stof stof merged commit 81c7853 into async-aws:master Jul 3, 2023
@stof stof deleted the result_member_type branch July 3, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse jderusse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stof @jderusse