Skip to content

Fix doc test #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 20, 2020
Merged

Fix doc test #729

merged 5 commits into from
May 20, 2020

Conversation

k-nasa
Copy link
Member

@k-nasa k-nasa commented Mar 18, 2020

  • Fix lib.rs doc test
  • Run ignored stream test
  • Fix stream::min and stream::max

@k-nasa k-nasa requested a review from a team March 27, 2020 08:07
dignifiedquire
dignifiedquire approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

dignifiedquire
dignifiedquire reviewed Apr 24, 2020
View reviewed changes
src/stream/stream/max.rs
@@ -11,29 +10,23 @@ use crate::task::{Context, Poll};
pin_project! {
#[doc(hidden)]
#[allow(missing_debug_implementations)]
pub struct MaxFuture<S, F, T> {
pub struct MaxFuture<S, T> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems unrelated, why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is unnecessary type argument.
Certainly that may be different from what I'm doing with this PR.

@k-nasa
Copy link
Member Author

k-nasa commented May 20, 2020

If pass ci, I merge it.

@k-nasa k-nasa merged commit 70dac51 into async-rs:master May 20, 2020
@k-nasa k-nasa deleted the fix_doc_test branch May 20, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-nasa @dignifiedquire