feat: add support for request and reply pattern by AceTheCreator · Pull Request #795 · asyncapi/asyncapi-react

AceTheCreator · 2023-10-02T14:12:12Z

This PR adds support for request and reply patterns by introducing a new component that renders reply information such as:

reply channel information such as address, description, message(s) and so on
Reply address information such as address, location, and description

AsyncApi.React.Playground.App.-.16.November.2023.mp4

This PR also fixes the PUB/SUB reversal experienced in this issue #815

cc @jonaslagoni @magicmatatjahu

…omponent. (asyncapi#323)

chore(release): v1.0.0-next.1

…message from oneOf (asyncapi#335)

chore(release): v1.0.0-next.2

chore(release): v1.0.0-next.3

)

chore(release): v1.0.0-next.4

derberg · 2023-11-06T15:17:30Z

dunno but can't refresh locally 🤷🏼
luckily I made it with gitpod: https://gitpod.io/#https://github.com/AceTheCreator/asyncapi-react/tree/req/rep

tested with https://raw.githubusercontent.com/asyncapi/spec/next-major-spec/examples/kraken-websocket-request-reply-multiple-channels-asyncapi.yml

issue: reply for subscribe operation do not have much channel details for reply, only reply address - missing info about messages. Basically Expected Reply Messages is missing

tested with https://raw.githubusercontent.com/asyncapi/spec/next-major-spec/examples/kraken-websocket-request-reply-message-filter-in-reply-asyncapi.yml and works like a charm

tested with https://raw.githubusercontent.com/asyncapi/spec/next-major-spec/examples/adeo-kafka-request-reply-asyncapi.yml

issue: Playground crash. Cannot figure errors, strange as latest parser is used and the bug with kafka binding was supposed to be fixed there. Will investigate

tested with https://raw.githubusercontent.com/asyncapi/spec/next-major-spec/examples/streetlights-kafka-asyncapi.yml

issue: no operations rendered, just Operations header

last but not least - I think #795 (comment) is broken again

library/src/containers/Operations/Operation.tsx

AceTheCreator · 2023-11-08T17:43:08Z

@derberg I added suggested changes. Kindly give it a look :)

derberg · 2023-11-13T09:37:35Z

tested with https://raw.githubusercontent.com/asyncapi/spec/next-major-spec/examples/adeo-kafka-request-reply-asyncapi.yml
issue: Playground crash. Cannot figure errors, strange as latest parser is used and the bug with kafka binding was supposed to be fixed there. Will investigate

did you have a chance to check what is wrong here?

tested with https://raw.githubusercontent.com/asyncapi/spec/next-major-spec/examples/streetlights-kafka-asyncapi.yml
issue: no operations rendered, just Operations header

Operations are still empty

also some issue with rendering of examples in reply

AceTheCreator · 2023-11-14T07:03:46Z

tested with https://raw.githubusercontent.com/asyncapi/spec/next-major-spec/examples/streetlights-kafka-asyncapi.yml
issue: no operations rendered, just Operations header

Operations are still empty

@derberg Based on my investigation, The issue is actually related to the way Parser is handling the Operation traits. I get the list of Operations only when I get rid of the traits.

cc @smoya

AceTheCreator · 2023-11-14T07:09:14Z

tested with https://raw.githubusercontent.com/asyncapi/spec/next-major-spec/examples/adeo-kafka-request-reply-asyncapi.yml
issue: Playground crash. Cannot figure errors, strange as latest parser is used and the bug with kafka binding was supposed to be fixed there. Will investigate

did you have a chance to check what is wrong here?

Same as last time. Playground only renders when I remove the Message level bindings 🤷🏾‍♂️

derberg · 2023-11-14T09:00:11Z

@AceTheCreator I see for message issue you have created asyncapi/parser-js#877, and what about operations? maybe update message-related issue or create a new one for operations

derberg · 2023-11-14T09:01:09Z

so in this PR only styling of examples left?

AceTheCreator · 2023-11-14T11:45:59Z

so in this PR only styling of examples left?

Yes

into HEAD

AceTheCreator · 2023-11-15T17:45:02Z

@derberg Examples styling fixed

derberg

2 small comments + please update description to reflect current state of the PR

then we can merge

derberg · 2023-11-16T10:08:09Z

library/package.json

    "@asyncapi/openapi-schema-parser": "3.0.4",
-    "@asyncapi/parser": "^2.1.1",
    "@asyncapi/protobuf-schema-parser": "3.0.0",
+    "@asyncapi/parser": "^3.0.0-next-major-spec.7",


please use latest v3.0.0-next-major-spec.10

derberg · 2023-11-16T10:08:44Z

playground/package.json

  },
  "scripts": {
-    "start": "react-app-rewired start",
+    "start": "react-app-rewired --openssl-legacy-provider start",


please revert, as with this I cannot start local playground anymore, and need to manually remove that flag

sonarqubecloud · 2023-11-16T13:21:22Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
2.0% Duplication

AceTheCreator · 2023-11-16T13:27:44Z

added suggested changes @derberg

derberg

awesome hard work!

derberg · 2023-11-16T15:34:11Z

/rtm

asyncapi-bot · 2023-11-16T15:50:00Z

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

magicmatatjahu and others added 30 commits March 18, 2021 12:32

refactor: switch to parser-js in most places (asyncapi#264)

afa84a8

refactor: rewrite Schema component (asyncapi#269)

a3d9ebf

refactor: rewritten Info component (asyncapi#277)

3d7c733

refactor: unify Messages and Operations components (asyncapi#276)

883916f

refactor: unify bindings and extensions (asyncapi#280)

6b2807c

refactor: remove leftover code (asyncapi#285)

ed84be2

refactor: unify Servers (asyncapi#288)

8b0288c

refactor: add sidebar and render examples (asyncapi#291)

ba91b1e

refactor: unify styling (asyncapi#296)

477f015

chore: add esm, cjs and umd bundles (asyncapi#297)

320c389

docs: unify documentation (asyncapi#302)

99969ac

ci: add bump workflow (asyncapi#307)

2ed20c1

refactor: remove unnecessary code (asyncapi#309)

2dcc730

refactor: unify styling vol.2 (asyncapi#310)

2bc32e8

ci: update workflows for next (asyncapi#322)

3f0c181

feat: next release. BREAKING CHANGE: unify html-template with react-c…

8144017

…omponent. (asyncapi#323)

ci: fix checkout to next branch (asyncapi#325)

da4fa1a

feat!: unify react-component with html-template (asyncapi#327)

6b64a64

chore(release): v1.0.0-next.1 (asyncapi#328)

85ac790

chore(release): v1.0.0-next.1

fix: strictly check if a given part of spec exists and render single …

aa03538

…message from oneOf (asyncapi#335)

chore(release): v1.0.0-next.2 (asyncapi#340)

2a5b42d

chore(release): v1.0.0-next.2

refactor: infer types in proper way and add tests (asyncapi#332)

3517888

chore: render schema dependencies (asyncapi#334)

704dd47

feat: render missed parts of spec (asyncapi#345)

0371914

chore(release): v1.0.0-next.3 (asyncapi#347)

164f289

chore(release): v1.0.0-next.3

ci: update semantic-release packages and related workflows (asyncapi#349

6f3a6ac

)

feat: update openapi-sampler package to 1.0.0 (asyncapi#355)

02c40d8

chore(release): v1.0.0-next.4 (asyncapi#359)

f1652df

chore(release): v1.0.0-next.4

ci: publish playground from next branch (asyncapi#352)

ed998f9

fix: rendering the circular items (asyncapi#356)

3ddad45

derberg reviewed Nov 6, 2023

View reviewed changes

library/src/containers/Operations/Operation.tsx Outdated Show resolved Hide resolved

added suggested changes

b02b897

derberg mentioned this pull request Nov 8, 2023

Studio renders PUB topics as SUB and SUB topics as PUB asyncapi/studio#845

Closed

added suggested changes

0532845

AceTheCreator added 3 commits November 15, 2023 18:21

fixed example stylling

a9717ea

returned old streetlight example

491fb99

Merge branch 'master' of https://github.com/AceTheCreator/asyncapi-react

f19d045

into HEAD

derberg changed the title ~~feat: added support for req/rep~~ feat: add support for request and reply pattern Nov 16, 2023

derberg requested changes Nov 16, 2023

View reviewed changes

AceTheCreator added 2 commits November 16, 2023 14:07

upgraded parser

a92ab98

fix span styling

267d43b

derberg approved these changes Nov 16, 2023

View reviewed changes

asyncapi-bot added the ready-to-merge label Nov 16, 2023

asyncapi-bot merged commit 12c339b into asyncapi:master Nov 16, 2023

asyncapi-bot added the released label Nov 16, 2023

derberg mentioned this pull request Nov 16, 2023

Reversed pub/sub action render? #815

Closed

jonaslagoni mentioned this pull request Jan 18, 2024

fix: sidebar navigation problems #887

Merged

Uh oh!

Conversation

AceTheCreator commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

derberg commented Nov 6, 2023

Uh oh!

Uh oh!

AceTheCreator commented Nov 8, 2023

Uh oh!

derberg commented Nov 13, 2023

Uh oh!

AceTheCreator commented Nov 14, 2023

Uh oh!

AceTheCreator commented Nov 14, 2023

Uh oh!

derberg commented Nov 14, 2023

Uh oh!

derberg commented Nov 14, 2023

Uh oh!

AceTheCreator commented Nov 14, 2023

Uh oh!

AceTheCreator commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

derberg left a comment

Choose a reason for hiding this comment

Uh oh!

derberg Nov 16, 2023

Choose a reason for hiding this comment

Uh oh!

derberg Nov 16, 2023

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Nov 16, 2023

Uh oh!

AceTheCreator commented Nov 16, 2023

Uh oh!

derberg left a comment

Choose a reason for hiding this comment

Uh oh!

derberg commented Nov 16, 2023

Uh oh!

asyncapi-bot commented Nov 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

AceTheCreator commented Oct 2, 2023 •

edited

Loading

AceTheCreator commented Nov 15, 2023 •

edited

Loading