fix(cli): parse GitHub URLs with slash-based branches and multi-dot spec files#2224
Closed
q404365631 wants to merge 2 commits into
Closed
fix(cli): parse GitHub URLs with slash-based branches and multi-dot spec files#2224q404365631 wants to merge 2 commits into
q404365631 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: d3a2c3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Fixes two validation bugs in the CLI described in #1940:
1. GitHub URL parsing (
validation.service.ts)The regex used to convert
https://github.com/owner/repo/blob/<branch>/<path>to the GitHub API URL only accepted a single-segment branch, so URLs likewere not matched and the API call 404'd. The fix captures everything after
/blob/, then heuristically splits off the trailing/<file>.{yaml,yml,json}portion as the file path (with everything before it as the branch). If the trailing portion doesn't have a known spec extension, it falls back to taking the first/-delimited segment as the branch.2. File extension detection (
SpecificationFile.ts)fileExists()usedname.split('.')[1]to extract the extension, which only returned the second segment. A file namedspec.test.yamlreturned"test"instead of"yaml"and was rejected. Switched topath.extname(name).slice(1).toLowerCase()which correctly returns the last extension.Why
Both bugs cause valid inputs to fail validation, as reported in #1940.
Changes
src/domains/services/validation.service.ts: Replaced the strict single-segment regex inconvertGitHubWebUrl()with a more permissive pattern + split heuristic.src/domains/models/SpecificationFile.ts: Replacedname.split('.')[1]withpath.extname(name).slice(1).toLowerCase()infileExists().pathwas already imported.2 files changed, 45 insertions(+), 4 deletions(-).
Testing
Verified manually with the example URLs from the issue:
https://github.com/org/repo/blob/feature/new-validation/spec.yaml→ resolves tohttps://api.github.com/repos/org/repo/contents/spec.yaml?ref=feature/new-validationspec.test.yaml→ extension correctly detected asyamlNo new automated tests added in this PR to keep it minimal — happy to follow up with a unit test file if the maintainers want.
Closes #1940
Part of MICROGRANT 2026-05 round (
#2125).