Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tweetLimit in community/newsroom isn't been reflected #3138

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+6 −1
Open

fix: tweetLimit in community/newsroom isn't been reflected #3138

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
faa5f6d
fix: handle uncontrolled twitter data load
Saumya40-codes Aug 9, 2024
260b950
update: height for info
Saumya40-codes Aug 9, 2024
564c14a
fix: linting
Saumya40-codes Aug 9, 2024
b0feb30
Merge branch 'master' into handle-twitter-data
asyncapi-bot Aug 30, 2024
b592742
Merge branch 'master' into handle-twitter-data
asyncapi-bot Aug 31, 2024
2ee2fb8
Merge branch 'master' into handle-twitter-data
asyncapi-bot Sep 13, 2024
920a568
Merge branch 'master' into handle-twitter-data
Saumya40-codes Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion components/newsroom/Newsroom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,12 @@ export default function Newsroom() {
</div>
<div className='w-full px-2 md:w-1/2 md:pl-4 md:pr-0'>
<div className='mx-auto mt-8 w-full rounded-xl shadow-md md:mt-0' data-testid='Newsroom-Twitter'>
<TwitterTimelineEmbed sourceType='profile' screenName='AsyncAPISpec' options={{ tweetLimit: '2' }} />
<TwitterTimelineEmbed
sourceType='profile'
screenName='AsyncAPISpec'
options={{ tweetLimit: '2', height: '600' }}
noScrollbar
/>
</div>
</div>
</div>
Saumya40-codes marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading