Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tried to fix the tweetLimit in community/newsroom route (Fixes #3132) #3220

Closed
wants to merge 1 commit into from

Conversation

hkv24
Copy link
Contributor

@hkv24 hkv24 commented Sep 12, 2024

Description

In Newsroom.tsx file <TwitterTimelineEmbed sourceType='profile' screenName='AsyncAPISpec' options={{ tweetLimit: 2 }} /> I changed the tweetLimit value to 2 (num) from '2' (string).

Resolves #3132

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a577037
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66e316dee2bc7d0008bb5eab
😎 Deploy Preview https://deploy-preview-3220--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hkv24 hkv24 changed the title fix: tried to fix the tweetLimit in community/newsroom route fix: tried to fix the tweetLimit in community/newsroom route (Fixes #3132) Sep 12, 2024
@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 40
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3220--asyncapi-website.netlify.app/

@sambhavgupta0705
Copy link
Member

closing this as there is already an issue for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] tweetLimit in community/newsroom isn't been reflected
3 participants