Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Ashmit Gupta as a code triager #3234

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

devilkiller-ag
Copy link
Member

Description
This PR will add Ashmit Gupta(@devilkiller-ag) as a code triager of the website

Copy link

netlify bot commented Sep 15, 2024

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 3744c3d
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/66e9b13eba87220008e9b540
😎 Deploy Preview https://deploy-preview-3234--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devilkiller-ag devilkiller-ag changed the title chore: add Ashmit Gupta as a code triager chore: add Ashmit Gupta(@devilkiller-ag) as a code triager Sep 15, 2024
@devilkiller-ag devilkiller-ag changed the title chore: add Ashmit Gupta(@devilkiller-ag) as a code triager chore: add Ashmit Gupta as a code triager Sep 15, 2024
@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Sep 15, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 47
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3234--asyncapi-website.netlify.app/

Copy link
Member

derberg commented Sep 17, 2024

if @akshatnema @anshgoyalevil and @sambhavgupta0705 are ok with that, I'm also

Copy link
Member

@anshgoyalevil anshgoyalevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side 🚀 🎊

@sambhavgupta0705 got a new companion 🤝

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval from my side 😄

@akshatnema
Copy link
Member

@sambhavgupta0705 your opinion?

Copy link
Member

@sambhavgupta0705 sambhavgupta0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sambhavgupta0705
Copy link
Member

/rtm

1 similar comment
@anshgoyalevil
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 7c989c4 into asyncapi:master Sep 17, 2024
16 checks passed
@devilkiller-ag devilkiller-ag deleted the update-code-triager branch September 17, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants