fix: update code to support @octokit/request v9 and @octokit/graphql v8 #3697
Conversation
AritraDey-Dev
requested review from
derberg,
akshatnema,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
|
Warning Rate limit exceeded@AritraDey-Dev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 7 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
AritraDey-Dev
changed the title
|
@AritraDey-Dev Make sure all the tests and build pass |
AritraDey-Dev
force-pushed
the
fix-octokit-upgrade
branch
from
1320dd5 to
2cad54c
Compare
This reverts commit 2cad54c.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
scripts/dashboard/build-dashboard.js (1)
180-180:⚠️ Potential issueUpdate the module execution check for ES modules
The
require.main === modulecheck is specific to CommonJS and won't work in an ES module environment. This line needs to be updated to the ES module equivalent.- if (require.main === module) { + if (import.meta.url === `file://${process.argv[1]}`) {
🧹 Nitpick comments (1)
scripts/dashboard/build-dashboard.js (1)
184-184: Successfully migrated to ES module exportsThe export statement has been correctly migrated from CommonJS
module.exportsto ES moduleexport.For better readability, consider formatting the exports with each name on a separate line as suggested by the linter:
- export { getLabel, monthsSince, mapGoodFirstIssues, getHotDiscussions, getDiscussionByID, getDiscussions, writeToFile, start, processHotDiscussions, pause }; + export { + getLabel, + monthsSince, + mapGoodFirstIssues, + getHotDiscussions, + getDiscussionByID, + getDiscussions, + writeToFile, + start, + processHotDiscussions, + pause + };🧰 Tools
🪛 ESLint
[error] 184-184: Replace
·getLabel,·monthsSince,·mapGoodFirstIssues,·getHotDiscussions,·getDiscussionByID,·getDiscussions,·writeToFile,·start,·processHotDiscussions,·pause·with⏎··getLabel,⏎··monthsSince,⏎··mapGoodFirstIssues,⏎··getHotDiscussions,⏎··getDiscussionByID,⏎··getDiscussions,⏎··writeToFile,⏎··start,⏎··processHotDiscussions,⏎··pause⏎(prettier/prettier)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
scripts/dashboard/build-dashboard.js(2 hunks)
🧰 Additional context used
🪛 ESLint
scripts/dashboard/build-dashboard.js
[error] 4-4: Unexpected use of file extension "js" for "./issue-queries.js"
(import/extensions)
[error] 184-184: Replace ·getLabel,·monthsSince,·mapGoodFirstIssues,·getHotDiscussions,·getDiscussionByID,·getDiscussions,·writeToFile,·start,·processHotDiscussions,·pause· with ⏎··getLabel,⏎··monthsSince,⏎··mapGoodFirstIssues,⏎··getHotDiscussions,⏎··getDiscussionByID,⏎··getDiscussions,⏎··writeToFile,⏎··start,⏎··processHotDiscussions,⏎··pause⏎
(prettier/prettier)
🔇 Additional comments (1)
scripts/dashboard/build-dashboard.js (1)
1-4: Successfully migrated to ES module importsThe imports have been properly migrated from CommonJS
requirestatements to ES moduleimportstatements, which aligns with the PR objective to update Octokit dependencies.Note: The ESLint warning about file extensions is a configuration issue. Including
.jsextensions in imports is actually required for ES modules in Node.js environments.🧰 Tools
🪛 ESLint
[error] 4-4: Unexpected use of file extension "js" for "./issue-queries.js"
(import/extensions)
fixes #3690
Description
Update
package.jsonto support@octokit/requestv9.2.2 and@octokit/graphqlv8.2.1.@octokit/graphqlto version8.2.1.@octokit/requestwith version9.2.2.Summary by CodeRabbit
>=16and npm version^8.0.0.