fix: fixed lighthouse ci test for pull requests on target branch #3753
Conversation
hkv24
requested review from
derberg,
akshatnema,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request updates the GitHub Actions workflow file by adding a Changes
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 180000ms (4)
🔇 Additional comments (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
asyncapi-bot
requested review from
devilkiller-ag,
sambhavgupta0705,
Aahil13 and
VaishnaviNandakumar
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3753 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 732 732
=========================================
Hits 732 732 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/lighthouse-ci.yml (1)
15-33: Refactored Conditional Logic for PR SkippingThe updated conditional section now clearly checks for multiple PR title prefixes associated with automated updates by both the asyncapi-bot and allcontributors[bot]. This compact structure is easier to maintain compared to more verbose formats. One suggestion: if the list of prefixes grows further, consider externalizing these values (if possible) to avoid repeating similar function calls.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/lighthouse-ci.yml(3 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (3)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
🔇 Additional comments (4)
.github/workflows/lighthouse-ci.yml (4)
18-25: Clear Definition of Title Skips for asyncapi-botThe conditions checking if the pull request title starts with:
"ci: update global workflows""chore: update code of conduct""ci: update global contribution guide""ci: update workflows for go projects""ci: update workflows for nodejs projects""ci: update release-related workflows for nodejs projects""ci: update semantic release config file""ci: update generic workflows"are clear and explicit. This ensures that non-functional updates do not trigger unnecessary Lighthouse CI runs.
29-31: Accurate Condition for allcontributors BotThe condition for PRs created by
allcontributors[bot]checking the title prefix"docs: add"is clear and correct, ensuring that documentation updates from this bot do not run the CI process.
58-58: Artifact Name Parameter AdditionThe new parameter
artifactName: lighthouse_resultsin the Lighthouse Audit step neatly categorizes the generated artifact. This should help with downstream processes consuming the artifact.
92-94: Token Reference CorrectionThe update of the token reference for the LightHouse Statistic Comment step—from using an outdated
secrets.GH_TOKENto the correctsecrets.GITHUB_TOKEN—ensures proper authentication and aligns with best practices in GitHub Actions.
|
The GH action is still failing |
Description
Related issue(s)
Refs #3751
Summary by CodeRabbit