-
-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added necessary ui changes as asked in Design Audit #3755
Open
NalinDalal
wants to merge
27
commits into
asyncapi:master
Choose a base branch
from
NalinDalal:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8,167
−9,029
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
857b12e
Added load more button in /blog endpoint, as it was asked in Design A…
NalinDalal 8d9e444
Added email validation, it was literally taking anything,check if the…
NalinDalal 65c110c
Removed redundancy, declared
NalinDalal 18a0b99
Refactor
NalinDalal 8f2db81
solved 5.2-> added necessary whitespaces to make it uniform
NalinDalal 408a649
Solved 5.4;Improve card visibility by adding necessary effects and st…
NalinDalal f1ed9cd
Solved 5.5
NalinDalal bb5b409
Added Linting on Docker also
NalinDalal 6aa277b
3A.1
NalinDalal 040c8d4
3A.2 the text is centered, we need to make it left aligned, problem i…
NalinDalal abd0a00
3A.3 move notified section b/f footer, a/f members- done
NalinDalal 6dec982
3B.1 Removed redundant button
NalinDalal bc9fe4a
Removed all linting error
NalinDalal c35a38c
4.1.1 improved card visibility using effect,strokes
NalinDalal 32a84d9
Improved text kerning from audit 06, 1.1
NalinDalal bdf35e2
Merge branch 'master' into master
NalinDalal daa8c41
Linting done
NalinDalal 5263c64
Updated Dockerfile
NalinDalal 9a8e679
03. Community
NalinDalal 1c54c67
Removed all linting error
NalinDalal 3baa21a
Merge branch 'master' into master
NalinDalal a665094
Section 1.14, 1.15; FAQs Added, Added hover for links
NalinDalal da56e10
Removed linting error
NalinDalal 308e459
Updated slack logo
NalinDalal c2e7593
Docker start application command updated
NalinDalal c8a655f
Merge branch 'asyncapi:master' into master
NalinDalal 684c6d8
ci test for lighthouse fixed
NalinDalal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,14 @@ import { initiativeLinks, socialMediaLinks } from './FooterList'; | |
/** | ||
* @description The Footer component is the footer for the application. | ||
*/ | ||
|
||
// FAQ Links | ||
const faqLinks = [ | ||
{ label: 'General Questions', url: '/faq#general' }, | ||
{ label: 'Getting Started', url: '/faq#getting-started' }, | ||
{ label: 'Technical Support', url: '/faq#technical-support' } | ||
]; | ||
|
||
export default function Footer() { | ||
return ( | ||
<footer className='margin: 0 auto mt-12 bg-dark'> | ||
|
@@ -43,7 +51,7 @@ export default function Footer() { | |
{initiativeLinks.map((link: InitiativeLink, index: number) => ( | ||
<li className='py-2' key={index} data-testid='Footer-initiative-links'> | ||
<Link href={link.url}> | ||
<span className='text-base leading-6 text-cool-gray transition duration-300 ease-in-out hover:text-white'> | ||
<span className='hover:text-primary text-base leading-6 text-cool-gray transition duration-300 ease-in-out'> | ||
{link.label} | ||
</span> | ||
</Link> | ||
|
@@ -60,14 +68,34 @@ export default function Footer() { | |
</div> | ||
<ul className='justify-center'> | ||
<li className='py-2'> | ||
<div className='text-base leading-6 text-cool-gray transition duration-300 ease-in-out hover:text-white'> | ||
<div className='hover:text-primary text-base leading-6 text-cool-gray transition duration-300 ease-in-out'> | ||
<a href='mailto:[email protected]'>Email Us</a> | ||
</div> | ||
</li> | ||
</ul> | ||
</div> | ||
</div> | ||
|
||
{/* FAQ Section */} | ||
<div className='mb-5 px-0 sm:ml-5 sm:px-10'> | ||
<div className='py-2'> | ||
<div className='text-white'> | ||
<Heading typeStyle={HeadingTypeStyle.smSemibold}>FAQs</Heading> | ||
</div> | ||
</div> | ||
<ul className='justify-center'> | ||
{faqLinks.map((link, index) => ( | ||
<li className='py-2' key={index}> | ||
<Link href={link.url}> | ||
<span className='hover:text-primary text-base leading-6 text-cool-gray transition duration-300 ease-in-out'> | ||
{link.label} | ||
</span> | ||
</Link> | ||
</li> | ||
))} | ||
</ul> | ||
</div> | ||
|
||
<div className='mb-5 px-0 sm:ml-5 sm:px-10'> | ||
<div className='hidden py-2 sm:block'> | ||
<div className='mr-12 text-white'> | ||
|
@@ -78,7 +106,7 @@ export default function Footer() { | |
{socialMediaLinks.map((link: SocialMediaLink, index: number) => ( | ||
<li className='mr-3 py-2 sm:mr-0' key={index} data-testid='Footer-social-media-links'> | ||
<a href={link.url} target='_blank' rel='noopener noreferrer'> | ||
<div className='flex items-center text-cool-gray transition duration-300 ease-in-out hover:text-white'> | ||
<div className='hover:text-primary flex items-center text-cool-gray transition duration-300 ease-in-out'> | ||
<span className='sr-only'>{`Follow AsyncAPI on ${link.label}`}</span> | ||
{link.icon} | ||
<span className='absolute hidden pl-8 pr-5 sm:block'>{link.label}</span> | ||
|
@@ -101,7 +129,7 @@ export default function Footer() { | |
policy and general project policies please see{' '} | ||
<a | ||
href='https://lfprojects.org' | ||
className='text-secondary-500 underline transition duration-300 ease-in-out hover:text-white' | ||
className='hover:text-primary text-secondary-500 underline transition duration-300 ease-in-out' | ||
target='_blank' | ||
rel='noopener noreferrer' | ||
> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix formatting issues with SVG paths
All path definitions need to use single quotes instead of double quotes to comply with the project's Prettier configuration.
📝 Committable suggestion
🧰 Tools
🪛 GitHub Actions: PR testing - if Node project
[error] 19-19: Replace
"M11.5·3A2.5·2.5·0·0·0·9·5.5a2.5·2.5·0·0·0·2.5·2.5H14V5.5A2.5·2.5·0·0·0·11.5·3Z"
with'M11.5·3A2.5·2.5·0·0·0·9·5.5a2.5·2.5·0·0·0·2.5·2.5H14V5.5A2.5·2.5·0·0·0·11.5·3Z'
prettier/prettier[error] 20-20: Replace
"M17.5·3A2.5·2.5·0·0·0·15·5.5v6a2.5·2.5·0·0·0·5·0v-6A2.5·2.5·0·0·0·17.5·3Z"
with'M17.5·3A2.5·2.5·0·0·0·15·5.5v6a2.5·2.5·0·0·0·5·0v-6A2.5·2.5·0·0·0·17.5·3Z'
prettier/prettier[error] 21-21: Replace
"M5.5·9A2.5·2.5·0·0·0·3·11.5a2.5·2.5·0·0·0·2.5·2.5h6a2.5·2.5·0·0·0·0-5h-6Z"
with'M5.5·9A2.5·2.5·0·0·0·3·11.5a2.5·2.5·0·0·0·2.5·2.5h6a2.5·2.5·0·0·0·0-5h-6Z'
prettier/prettier[error] 22-22: Replace
"M23.5·9A2.5·2.5·0·0·0·21·11.5V14h2.5a2.5·2.5·0·0·0·2.5-2.5A2.5·2.5·0·0·0·23.5·9Z"
with'M23.5·9A2.5·2.5·0·0·0·21·11.5V14h2.5a2.5·2.5·0·0·0·2.5-2.5A2.5·2.5·0·0·0·23.5·9Z'
prettier/prettier[error] 23-23: Replace
"M5.5·15A2.5·2.5·0·0·0·3·17.5a2.5·2.5·0·0·0·2.5·2.5A2.5·2.5·0·0·0·8·17.5V15H5.5Z"
with'M5.5·15A2.5·2.5·0·0·0·3·17.5a2.5·2.5·0·0·0·2.5·2.5A2.5·2.5·0·0·0·8·17.5V15H5.5Z'
prettier/prettier[error] 24-24: Replace
"M11.5·15A2.5·2.5·0·0·0·9·17.5v6a2.5·2.5·0·0·0·5·0v-6A2.5·2.5·0·0·0·11.5·15Z"
with'M11.5·15A2.5·2.5·0·0·0·9·17.5v6a2.5·2.5·0·0·0·5·0v-6A2.5·2.5·0·0·0·11.5·15Z'
prettier/prettier[error] 25-25: Replace
"M17.5·15A2.5·2.5·0·0·0·15·17.5a2.5·2.5·0·0·0·2.5·2.5h6a2.5·2.5·0·0·0·0-5h-6Z"
with'M17.5·15A2.5·2.5·0·0·0·15·17.5a2.5·2.5·0·0·0·2.5·2.5h6a2.5·2.5·0·0·0·0-5h-6Z'
prettier/prettier[error] 26-26: Replace
"M15·21v2.5a2.5·2.5·0·0·0·5·0·2.5·2.5·0·0·0-2.5-2.5H15Z"
with'M15·21v2.5a2.5·2.5·0·0·0·5·0·2.5·2.5·0·0·0-2.5-2.5H15Z'
prettier/prettier