-
-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix broken link in the tools section #3806
Conversation
Fixes asyncapi#3797 Remove the `View Website` button from the `AsyncAPI Server API` card in the `components/tools/ToolsCard.tsx` file. * Update the condition to check for `toolData.links.repoUrl` or `toolData.links.docsUrl` instead of `toolData.links.repoUrl` or `toolData.links.websiteUrl` or `toolData.links.docsUrl`. * Remove the code block that renders the `View Website` button for `toolData.links.websiteUrl`.
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant ToolsCard
ToolsCard->>ToolsCard: Check for repoUrl
alt repoUrl exists
ToolsCard->>Output: Render Repository Link
end
ToolsCard->>ToolsCard: Check for docsUrl
alt docsUrl exists
ToolsCard->>Output: Render Documentation Link
end
Note over ToolsCard: Website URL check removed.
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 180000ms (4)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3806 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #3797
Remove the
View Website
button from theAsyncAPI Server API
card in thecomponents/tools/ToolsCard.tsx
file.toolData.links.repoUrl
ortoolData.links.docsUrl
instead oftoolData.links.repoUrl
ortoolData.links.websiteUrl
ortoolData.links.docsUrl
.View Website
button fortoolData.links.websiteUrl
.Summary by CodeRabbit