Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix broken link in the tools section #3806

Closed
wants to merge 2 commits into from

Conversation

Recxsmacx
Copy link

@Recxsmacx Recxsmacx commented Mar 6, 2025

Fixes #3797

Remove the View Website button from the AsyncAPI Server API card in the components/tools/ToolsCard.tsx file.

  • Update the condition to check for toolData.links.repoUrl or toolData.links.docsUrl instead of toolData.links.repoUrl or toolData.links.websiteUrl or toolData.links.docsUrl.
  • Remove the code block that renders the View Website button for toolData.links.websiteUrl.

Summary by CodeRabbit

  • Refactor
    • Streamlined the tool display by removing the website link option, so now only repository and documentation links are shown when available.

Fixes asyncapi#3797

Remove the `View Website` button from the `AsyncAPI Server API` card in the `components/tools/ToolsCard.tsx` file.

* Update the condition to check for `toolData.links.repoUrl` or `toolData.links.docsUrl` instead of `toolData.links.repoUrl` or `toolData.links.websiteUrl` or `toolData.links.docsUrl`.
* Remove the code block that renders the `View Website` button for `toolData.links.websiteUrl`.
Copy link
Contributor

coderabbitai bot commented Mar 6, 2025

Walkthrough

The ToolsCard component has been updated by removing the conditional rendering for the websiteUrl link. The JSX now exclusively checks for and renders links for repoUrl and docsUrl, and all related elements for the website link have been removed. No changes have been made to any public or exported declarations.

Changes

File Changes Summary
components/tools/ToolsCard.tsx Removed the conditional rendering and associated JSX for the websiteUrl; now only renders links for repoUrl and docsUrl.

Sequence Diagram(s)

sequenceDiagram
    participant ToolsCard
    ToolsCard->>ToolsCard: Check for repoUrl
    alt repoUrl exists
        ToolsCard->>Output: Render Repository Link
    end
    ToolsCard->>ToolsCard: Check for docsUrl
    alt docsUrl exists
        ToolsCard->>Output: Render Documentation Link
    end
    Note over ToolsCard: Website URL check removed.
Loading

Suggested labels

ready-to-merge

Suggested reviewers

  • derberg
  • magicmatatjahu
  • devilkiller-ag
  • akshatnema
  • sambhavgupta0705
  • anshgoyalevil
  • asyncapi-bot-eve
  • Mayaleeeee

Poem

I'm a rabbit hopping through the code so fine,
No website link to chase, the logic now aligns.
Only repo and docs grace this digital dell,
Clean paths and clear renders, all working quite well.
With every line I nibble, I cheer—code magic as it dwells!
🥕💻


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87ace8a and 4213880.

📒 Files selected for processing (1)
  • components/tools/ToolsCard.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (4)
  • GitHub Check: Redirect rules - asyncapi-website
  • GitHub Check: Header rules - asyncapi-website
  • GitHub Check: Pages changed - asyncapi-website
  • GitHub Check: Lighthouse CI
🔇 Additional comments (1)
components/tools/ToolsCard.tsx (1)

171-171: Well-implemented fix for the broken link issue.

The condition has been updated to only check for repository and documentation URLs, effectively removing the "View Website" button as described in the PR objectives. This is an appropriate solution for fixing the broken link in the AsyncAPI Server API card.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9735691
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/67cb325e74eca50008fd3ecc
😎 Deploy Preview https://deploy-preview-3806--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Recxsmacx Recxsmacx changed the title fix : fix broken link in the tools section fix: fix broken link in the tools section Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1840f32) to head (9735691).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3806   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          667       667           
  Branches       113       113           
=========================================
  Hits           667       667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Recxsmacx Recxsmacx closed this Mar 7, 2025
@Recxsmacx Recxsmacx deleted the fix-broken-link branch March 7, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Broken link in the tools section
2 participants