I fix issue of icon #3816
I fix issue of icon #3816
Conversation
Aditya90456
requested review from
derberg,
akshatnema,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe changes update the project's dependencies and improve the ambassadors page. In Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant A as AmbassadorsComponent
participant D as SocialMediaData
U->>A: Navigate to ambassadors page
A->>D: Request social media URLs
alt URL exists
D-->>A: Return URL data
A->>A: Render icon (Github/Linkedin/Twitter)
else URL missing
D-->>A: Return missing flag
A->>A: Skip rendering for this platform
end
A->>U: Display updated social links
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used🪛 ESLintpages/community/ambassadors/index.tsx[error] 2-2: Trailing spaces not allowed. (no-trailing-spaces) [error] 2-2: Delete (prettier/prettier) [error] 143-143: Delete (prettier/prettier) [error] 144-144: Insert (prettier/prettier) [error] 145-145: Replace (prettier/prettier) [error] 146-146: Insert (prettier/prettier) [error] 147-147: Insert (prettier/prettier) [error] 148-148: Insert (prettier/prettier) [error] 149-149: Insert (prettier/prettier) [error] 150-150: Insert (prettier/prettier) [error] 151-151: Replace (prettier/prettier) [error] 152-152: Insert (prettier/prettier) [error] 153-153: Insert (prettier/prettier) [error] 154-154: Insert (prettier/prettier) [error] 155-155: Insert (prettier/prettier) [error] 156-156: Insert (prettier/prettier) [error] 157-157: Replace (prettier/prettier) [error] 158-158: Insert (prettier/prettier) [error] 159-159: Insert (prettier/prettier) [error] 160-160: Insert (prettier/prettier) [error] 161-161: Insert (prettier/prettier) [error] 162-164: Replace (prettier/prettier) 🪛 GitHub Actions: PR testing - if Node projectpages/community/ambassadors/index.tsx[error] 1-1: Run autofix to sort these imports! simple-import-sort/imports [error] 2-2: Trailing spaces not allowed. no-trailing-spaces [error] 2-2: Delete [error] 143-143: Delete [error] 144-144: Insert [error] 145-145: Replace [warning] 145-145: Invalid Tailwind CSS classnames order tailwindcss/classnames-order [error] 146-146: Insert [error] 147-147: Insert [error] 148-148: Insert [error] 149-149: Insert [error] 150-150: Insert [error] 151-151: Replace [warning] 151-151: Invalid Tailwind CSS classnames order tailwindcss/classnames-order [error] 152-152: Insert [error] 153-153: Insert [error] 154-154: Insert [error] 155-155: Insert [error] 156-156: Insert [error] 157-157: Replace [warning] 157-157: Invalid Tailwind CSS classnames order tailwindcss/classnames-order [error] 158-158: Insert [error] 159-159: Insert [error] 160-160: Insert [error] 161-161: Insert [error] 162-162: Replace [error] 164-164: More than 1 blank line not allowed. no-multiple-empty-lines 🔇 Additional comments (4)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
We require all PRs to follow Conventional Commits specification. |
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
package.json(2 hunks)pages/community/ambassadors/index.tsx(2 hunks)
🧰 Additional context used
🪛 ESLint
pages/community/ambassadors/index.tsx
[error] 144-144: Insert ·
(prettier/prettier)
[error] 145-145: Insert ················
(prettier/prettier)
[error] 146-146: Replace <a·href={ambassador.twitterUrl}·target='_blank'·rel='noreferrer'·className='underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.twitterUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='underline·flex·items-center·gap-1'⏎····················
(prettier/prettier)
[error] 147-147: Insert ················
(prettier/prettier)
[error] 148-148: Insert ················
(prettier/prettier)
[error] 149-149: Insert ················
(prettier/prettier)
[error] 150-150: Insert ················
(prettier/prettier)
[error] 151-151: Insert ················
(prettier/prettier)
[error] 152-152: Replace ····<a·href={ambassador.githubUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1' with ····················<a⏎······················href={ambassador.githubUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎····················
(prettier/prettier)
[error] 153-153: Insert ················
(prettier/prettier)
[error] 154-154: Insert ················
(prettier/prettier)
[error] 155-155: Insert ················
(prettier/prettier)
[error] 156-156: Insert ················
(prettier/prettier)
[error] 157-157: Insert ················
(prettier/prettier)
[error] 158-158: Replace <a·href={ambassador.linkedinUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.linkedinUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎····················
(prettier/prettier)
[error] 159-159: Insert ················
(prettier/prettier)
[error] 160-160: Insert ················
(prettier/prettier)
[error] 161-161: Insert ················
(prettier/prettier)
[error] 162-162: Insert ················
(prettier/prettier)
[error] 163-165: Replace </div>⏎⏎ with ················</div>
(prettier/prettier)
🪛 GitHub Actions: PR testing - if Node project
pages/community/ambassadors/index.tsx
[error] 1-1: Run autofix to sort these imports! simple-import-sort/imports
[error] 144-144: Insert · prettier/prettier
[error] 145-145: Insert ················ prettier/prettier
[error] 146-146: Replace <a·href={ambassador.twitterUrl}·target='_blank'·rel='noreferrer'·className='underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.twitterUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='underline·flex·items-center·gap-1'⏎···················· prettier/prettier
[warning] 146-146: Invalid Tailwind CSS classnames order tailwindcss/classnames-order
[error] 147-147: Insert ················ prettier/prettier
[error] 148-148: Insert ················ prettier/prettier
[error] 149-149: Insert ················ prettier/prettier
[error] 150-150: Insert ················ prettier/prettier
[error] 151-151: Insert ················ prettier/prettier
[error] 152-152: Replace ····<a·href={ambassador.githubUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1' with ····················<a⏎······················href={ambassador.githubUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎···················· prettier/prettier
[warning] 152-152: Invalid Tailwind CSS classnames order tailwindcss/classnames-order
[error] 153-153: Insert ················ prettier/prettier
[error] 154-154: Insert ················ prettier/prettier
[error] 155-155: Insert ················ prettier/prettier
[error] 156-156: Insert ················ prettier/prettier
[error] 157-157: Insert ················ prettier/prettier
[error] 158-158: Replace <a·href={ambassador.linkedinUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.linkedinUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎···················· prettier/prettier
[warning] 158-158: Invalid Tailwind CSS classnames order tailwindcss/classnames-order
[error] 159-159: Insert ················ prettier/prettier
[error] 160-160: Insert ················ prettier/prettier
[error] 161-161: Insert ················ prettier/prettier
[error] 162-162: Replace </div>⏎⏎ with ················</div> prettier/prettier
[error] 165-165: More than 1 blank line not allowed. no-multiple-empty-lines
⏰ Context from checks skipped due to timeout of 180000ms (4)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Lighthouse CI
🔇 Additional comments (5)
package.json (3)
84-84: Good addition of thelucide-reactlibrary.This addition enables the use of modern React icon components in the project, which are being utilized in the ambassadors page.
98-98:✅ Verification successful
Verify React version compatibility.
The React version has been updated to ^18.3.1 which is a very recent release. Ensure this version is compatible with all other dependencies in the project.
🌐 Web query:
Is React 18.3.1 stable and what are the compatibility considerations?💡 Result:
React 18.3.1 is a stable release that introduces warnings for deprecated APIs ahead of React 19 while maintaining backward compatibility for most applications. Here's a breakdown of its stability and compatibility considerations:
Stability
- Production-ready: The version is marked for production use, with performance optimizations and stripped error messages in production builds[7][10].
- Deprecation warnings: It adds warnings for APIs like
findDOMNode, string refs, anddefaultPropsin function components, helping developers prepare for React 19[1][8].- Server Components: Features like React Server Components (RSC) and associated directives are now stable[1].
Compatibility Considerations
Third-party Libraries
- Testing libraries like
react-testing-libraryrequire updates to support React 18.3.1[9].- CSS-in-JS libraries may need to adopt
useInsertionEffectfor optimal performance[2][4].Tooling Issues
- Vite users reported React DOM compatibility errors when using Remix, requiring either configuration adjustments or temporary downgrades to 18.2[6].
- TypeScript users must update
@types/reactand@types/react-domto match 18.3.1's stricter type definitions[2].Upgrade Path
- Recommended as preparation for React 19 migration[8].
- No significant bundle size or performance regressions compared to 18.2 based on community benchmarks[5].
Deprecated APIs
react-dom/test-utilsmethods are being phased out in favor of@testing-libraryalternatives[8].- Legacy context API and string refs now trigger warnings in non-StrictMode environments[1].
For most projects, upgrading to 18.3.1 is safe and recommended. However, teams using bleeding-edge tools like Vite or specific React Native architectures should verify compatibility before deploying[6][4]. The release serves as a stable bridge between React 18's concurrent features and the upcoming React 19 changes[8][10].
Citations:
- 1: https://github.com/facebook/react/releases
- 2: https://react.dev/blog/2022/03/08/react-18-upgrade-guide
- 3: https://www.gitclear.com/open_repos/facebook/react/release/v18.3.1
- 4: https://react.dev/blog/2022/03/29/react-v18
- 5: https://www.youtube.com/watch?v=0I25Ch3h1Eg
- 6: https://thinktank.ottomator.ai/t/react-18-3-1-vite-compatibility/1304
- 7: https://www.npmjs.com/package/react/v/18.3.1
- 8: https://socket.dev/npm/package/react
- 9: Support React 18.3 testing-library/react-testing-library#1314
- 10: https://www.npmjs.com/package/react?activeTab=versions
React 18.3.1 Update Verified – Compatibility Checks Recommended
The React version update to "^18.3.1" in
package.jsonhas been verified as a stable, production-ready release. It introduces deprecation warnings for certain APIs (such asfindDOMNodeand string refs) to guide future changes in React 19. However, ensure that:
- Third-party libraries (e.g., testing libraries like react-testing-library) are updated and compatible with this release.
- TypeScript definitions (
@types/reactand@types/react-dom) are aligned with React 18.3.1 if your project uses TypeScript.- Build tool configurations (like those in Vite/Remix setups) are adjusted if necessary to address any potential compatibility issues.
No immediate changes are required on this update, but please review your project's dependencies to confirm that they fully support React 18.3.1.
100-100:✅ Verification successful
Unused dependency added.
The
react-featherpackage appears to be added but not used in the codebase. The social media icons are being imported fromlucide-reactinstead.
🏁 Script executed:
#!/bin/bash # Check if react-feather is used anywhere in the codebase echo "Searching for react-feather imports..." rg -l "from ['|\"]react-feather" --type tsx --type jsx --type ts --type jsLength of output: 193
Please run the above script to verify if there are any occurrences of "react-feather" being imported anywhere in the codebase. The previous script failed due to an unrecognized file type for "tsx". Once you've confirmed that no imports exist (i.e. the search returns no files), you can safely conclude that the dependency is unused.
**Action: Consider Removing Unused Dependency** The `react-feather` package, listed in `package.json` at line 100, appears to be unused in the codebase. All social media icons are imported from `lucide-react`, and a repository-wide search (after excluding file type filters) should confirm that no files import `react-feather`. Please verify with the updated search script above; if no occurrences are found, remove the dependency from `package.json` to keep the project clean. --- 🏁 Script executed: ```shell #!/bin/bash echo "Performing a repository-wide search for 'react-feather' (ignoring file type filters)..." rg -l "from ['\"]react-feather" .Length of output: 350
Manual Check Recommended: Unused Dependency
The dependency
react-featheris declared inpackage.json(line 100) but does not appear to be used anywhere in the codebase—the social media icons are imported fromlucide-react. Because the initial automated search yielded no output (and had an error stemming from the `` annotation), please run the corrected command above to manually confirm that there are no references toreact-feather. If the command returns no matches, safely remove the dependency to keep the project clean.
🏁 Script executed:
#!/bin/bash # Please run this script manually (without the annotation) to re-verify: echo "Searching the repository for any reference to 'react-feather'..." rg -il "react-feather" .Length of output: 204
Action: Remove Unused Dependency "react-feather"
The dependency
"react-feather"is declared inpackage.jsonat line 100, but a repository-wide search confirms that it isn’t imported in any of the code files, as all social media icons are instead imported from"lucide-react". The only references to"react-feather"are its declarations inpackage.jsonandpackage-lock.json. Please remove the unused dependency to clean up the project.pages/community/ambassadors/index.tsx (2)
4-4: Good use of modern icon components.The imported icon components from
lucide-reactwill provide a more consistent and maintainable approach to rendering social icons.
144-163: Good improvement on conditional social links rendering.The conditional rendering of social media links is a good improvement as it ensures links are only displayed when the user has provided corresponding URLs. This enhances the user experience by preventing empty or broken links.
🧰 Tools
🪛 ESLint
[error] 144-144: Insert
·(prettier/prettier)
[error] 145-145: Insert
················(prettier/prettier)
[error] 146-146: Replace
<a·href={ambassador.twitterUrl}·target='_blank'·rel='noreferrer'·className='underline·flex·items-center·gap-1'with················<a⏎······················href={ambassador.twitterUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='underline·flex·items-center·gap-1'⏎····················(prettier/prettier)
[error] 147-147: Insert
················(prettier/prettier)
[error] 148-148: Insert
················(prettier/prettier)
[error] 149-149: Insert
················(prettier/prettier)
[error] 150-150: Insert
················(prettier/prettier)
[error] 151-151: Insert
················(prettier/prettier)
[error] 152-152: Replace
····<a·href={ambassador.githubUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1'with····················<a⏎······················href={ambassador.githubUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎····················(prettier/prettier)
[error] 153-153: Insert
················(prettier/prettier)
[error] 154-154: Insert
················(prettier/prettier)
[error] 155-155: Insert
················(prettier/prettier)
[error] 156-156: Insert
················(prettier/prettier)
[error] 157-157: Insert
················(prettier/prettier)
[error] 158-158: Replace
<a·href={ambassador.linkedinUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1'with················<a⏎······················href={ambassador.linkedinUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎····················(prettier/prettier)
[error] 159-159: Insert
················(prettier/prettier)
[error] 160-160: Insert
················(prettier/prettier)
[error] 161-161: Insert
················(prettier/prettier)
[error] 162-162: Insert
················(prettier/prettier)
🪛 GitHub Actions: PR testing - if Node project
[error] 144-144: Insert
·prettier/prettier
[error] 145-145: Insert
················prettier/prettier
[error] 146-146: Replace
<a·href={ambassador.twitterUrl}·target='_blank'·rel='noreferrer'·className='underline·flex·items-center·gap-1'with················<a⏎······················href={ambassador.twitterUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='underline·flex·items-center·gap-1'⏎····················prettier/prettier
[warning] 146-146: Invalid Tailwind CSS classnames order tailwindcss/classnames-order
[error] 147-147: Insert
················prettier/prettier
[error] 148-148: Insert
················prettier/prettier
[error] 149-149: Insert
················prettier/prettier
[error] 150-150: Insert
················prettier/prettier
[error] 151-151: Insert
················prettier/prettier
[error] 152-152: Replace
····<a·href={ambassador.githubUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1'with····················<a⏎······················href={ambassador.githubUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎····················prettier/prettier
[warning] 152-152: Invalid Tailwind CSS classnames order tailwindcss/classnames-order
[error] 153-153: Insert
················prettier/prettier
[error] 154-154: Insert
················prettier/prettier
[error] 155-155: Insert
················prettier/prettier
[error] 156-156: Insert
················prettier/prettier
[error] 157-157: Insert
················prettier/prettier
[error] 158-158: Replace
<a·href={ambassador.linkedinUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1'with················<a⏎······················href={ambassador.linkedinUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎····················prettier/prettier
[warning] 158-158: Invalid Tailwind CSS classnames order tailwindcss/classnames-order
[error] 159-159: Insert
················prettier/prettier
[error] 160-160: Insert
················prettier/prettier
[error] 161-161: Insert
················prettier/prettier
[error] 162-162: Replace
</div>⏎⏎with················</div>prettier/prettier
|
|
||
|
|
There was a problem hiding this comment.
Remove extra blank lines.
The pipeline is failing due to extra blank lines.
-
-📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
🧰 Tools
🪛 ESLint
[error] 163-165: Replace </div>⏎⏎ with ················</div>
(prettier/prettier)
🪛 GitHub Actions: PR testing - if Node project
[error] 165-165: More than 1 blank line not allowed. no-multiple-empty-lines
| <div className='flex border-t p-2' data-testid='Ambassadors-members-socials'> | ||
| {ambassador.twitterUrl && ( | ||
| <a href={ambassador.twitterUrl} target='_blank' rel='noreferrer' className='underline flex items-center gap-1'> | ||
| <Twitter size={16} className='text-blue-400' /> | ||
| </a> | ||
| )} | ||
| {ambassador.githubUrl && ( | ||
| <a href={ambassador.githubUrl} target='_blank' rel='noreferrer' className='ml-3 underline flex items-center gap-1'> | ||
| <Github size={16} className='text-gray-700' /> | ||
| Github | ||
| </a> | ||
| )} | ||
| {ambassador.linkedinUrl && ( | ||
| <a href={ambassador.linkedinUrl} target='_blank' rel='noreferrer' className='ml-3 underline flex items-center gap-1'> | ||
| <Linkedin size={16} className='text-blue-600' /> | ||
| </a> | ||
| )} | ||
| </div> |
There was a problem hiding this comment.
Fix formatting issues and correct Tailwind class order.
The conditional rendering of social media links is a good improvement, but there are formatting issues that are causing pipeline failures.
Apply these formatting fixes:
- <div className='flex border-t p-2' data-testid='Ambassadors-members-socials'>
- {ambassador.twitterUrl && (
- <a href={ambassador.twitterUrl} target='_blank' rel='noreferrer' className='underline flex items-center gap-1'>
- <Twitter size={16} className='text-blue-400' />
- Twitter
- </a>
- )}
- {ambassador.githubUrl && (
- <a href={ambassador.githubUrl} target='_blank' rel='noreferrer' className='ml-3 underline flex items-center gap-1'>
- <Github size={16} className='text-gray-700' />
- Github
- </a>
- )}
- {ambassador.linkedinUrl && (
- <a href={ambassador.linkedinUrl} target='_blank' rel='noreferrer' className='ml-3 underline flex items-center gap-1'>
- <Linkedin size={16} className='text-blue-600' />
- Linkedin
- </a>
- )}
-</div>
+ <div className='flex border-t p-2' data-testid='Ambassadors-members-socials'>
+ {ambassador.twitterUrl && (
+ <a
+ href={ambassador.twitterUrl}
+ target='_blank'
+ rel='noreferrer'
+ className='flex items-center gap-1 underline'
+ >
+ <Twitter size={16} className='text-blue-400' />
+ Twitter
+ </a>
+ )}
+ {ambassador.githubUrl && (
+ <a
+ href={ambassador.githubUrl}
+ target='_blank'
+ rel='noreferrer'
+ className='ml-3 flex items-center gap-1 underline'
+ >
+ <Github size={16} className='text-gray-700' />
+ Github
+ </a>
+ )}
+ {ambassador.linkedinUrl && (
+ <a
+ href={ambassador.linkedinUrl}
+ target='_blank'
+ rel='noreferrer'
+ className='ml-3 flex items-center gap-1 underline'
+ >
+ <Linkedin size={16} className='text-blue-600' />
+ Linkedin
+ </a>
+ )}
+ </div>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <div className='flex border-t p-2' data-testid='Ambassadors-members-socials'> | |
| {ambassador.twitterUrl && ( | |
| <a href={ambassador.twitterUrl} target='_blank' rel='noreferrer' className='underline flex items-center gap-1'> | |
| <Twitter size={16} className='text-blue-400' /> | |
| </a> | |
| )} | |
| {ambassador.githubUrl && ( | |
| <a href={ambassador.githubUrl} target='_blank' rel='noreferrer' className='ml-3 underline flex items-center gap-1'> | |
| <Github size={16} className='text-gray-700' /> | |
| Github | |
| </a> | |
| )} | |
| {ambassador.linkedinUrl && ( | |
| <a href={ambassador.linkedinUrl} target='_blank' rel='noreferrer' className='ml-3 underline flex items-center gap-1'> | |
| <Linkedin size={16} className='text-blue-600' /> | |
| </a> | |
| )} | |
| </div> | |
| <div className='flex border-t p-2' data-testid='Ambassadors-members-socials'> | |
| {ambassador.twitterUrl && ( | |
| <a | |
| href={ambassador.twitterUrl} | |
| target='_blank' | |
| rel='noreferrer' | |
| className='flex items-center gap-1 underline' | |
| > | |
| <Twitter size={16} className='text-blue-400' /> | |
| </a> | |
| )} | |
| {ambassador.githubUrl && ( | |
| <a | |
| href={ambassador.githubUrl} | |
| target='_blank' | |
| rel='noreferrer' | |
| className='ml-3 flex items-center gap-1 underline' | |
| > | |
| <Github size={16} className='text-gray-700' /> | |
| Github | |
| </a> | |
| )} | |
| {ambassador.linkedinUrl && ( | |
| <a | |
| href={ambassador.linkedinUrl} | |
| target='_blank' | |
| rel='noreferrer' | |
| className='ml-3 flex items-center gap-1 underline' | |
| > | |
| <Linkedin size={16} className='text-blue-600' /> | |
| </a> | |
| )} | |
| </div> |
🧰 Tools
🪛 ESLint
[error] 144-144: Insert ·
(prettier/prettier)
[error] 145-145: Insert ················
(prettier/prettier)
[error] 146-146: Replace <a·href={ambassador.twitterUrl}·target='_blank'·rel='noreferrer'·className='underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.twitterUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='underline·flex·items-center·gap-1'⏎····················
(prettier/prettier)
[error] 147-147: Insert ················
(prettier/prettier)
[error] 148-148: Insert ················
(prettier/prettier)
[error] 149-149: Insert ················
(prettier/prettier)
[error] 150-150: Insert ················
(prettier/prettier)
[error] 151-151: Insert ················
(prettier/prettier)
[error] 152-152: Replace ····<a·href={ambassador.githubUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1' with ····················<a⏎······················href={ambassador.githubUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎····················
(prettier/prettier)
[error] 153-153: Insert ················
(prettier/prettier)
[error] 154-154: Insert ················
(prettier/prettier)
[error] 155-155: Insert ················
(prettier/prettier)
[error] 156-156: Insert ················
(prettier/prettier)
[error] 157-157: Insert ················
(prettier/prettier)
[error] 158-158: Replace <a·href={ambassador.linkedinUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.linkedinUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎····················
(prettier/prettier)
[error] 159-159: Insert ················
(prettier/prettier)
[error] 160-160: Insert ················
(prettier/prettier)
[error] 161-161: Insert ················
(prettier/prettier)
[error] 162-162: Insert ················
(prettier/prettier)
🪛 GitHub Actions: PR testing - if Node project
[error] 144-144: Insert · prettier/prettier
[error] 145-145: Insert ················ prettier/prettier
[error] 146-146: Replace <a·href={ambassador.twitterUrl}·target='_blank'·rel='noreferrer'·className='underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.twitterUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='underline·flex·items-center·gap-1'⏎···················· prettier/prettier
[warning] 146-146: Invalid Tailwind CSS classnames order tailwindcss/classnames-order
[error] 147-147: Insert ················ prettier/prettier
[error] 148-148: Insert ················ prettier/prettier
[error] 149-149: Insert ················ prettier/prettier
[error] 150-150: Insert ················ prettier/prettier
[error] 151-151: Insert ················ prettier/prettier
[error] 152-152: Replace ····<a·href={ambassador.githubUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1' with ····················<a⏎······················href={ambassador.githubUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎···················· prettier/prettier
[warning] 152-152: Invalid Tailwind CSS classnames order tailwindcss/classnames-order
[error] 153-153: Insert ················ prettier/prettier
[error] 154-154: Insert ················ prettier/prettier
[error] 155-155: Insert ················ prettier/prettier
[error] 156-156: Insert ················ prettier/prettier
[error] 157-157: Insert ················ prettier/prettier
[error] 158-158: Replace <a·href={ambassador.linkedinUrl}·target='_blank'·rel='noreferrer'·className='ml-3·underline·flex·items-center·gap-1' with ················<a⏎······················href={ambassador.linkedinUrl}⏎······················target='_blank'⏎······················rel='noreferrer'⏎······················className='ml-3·underline·flex·items-center·gap-1'⏎···················· prettier/prettier
[warning] 158-158: Invalid Tailwind CSS classnames order tailwindcss/classnames-order
[error] 159-159: Insert ················ prettier/prettier
[error] 160-160: Insert ················ prettier/prettier
[error] 161-161: Insert ················ prettier/prettier
[error] 162-162: Replace </div>⏎⏎ with ················</div> prettier/prettier
| import { sortBy } from 'lodash'; | ||
| import Link from 'next/link'; | ||
| import React from 'react'; | ||
| import { Github, Linkedin, Twitter } from 'lucide-react'; |
There was a problem hiding this comment.
Fix import sorting.
The pipeline is failing due to incorrect import order. The imports need to be sorted according to the project's guidelines.
import { sortBy } from 'lodash';
import Link from 'next/link';
-import React from 'react';
import { Github, Linkedin, Twitter } from 'lucide-react';
+import React from 'react';Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 ESLint
[error] 1-14: Run autofix to sort these imports!
(simple-import-sort/imports)
🪛 GitHub Actions: PR testing - if Node project
[error] 1-1: Run autofix to sort these imports! simple-import-sort/imports
Summary by CodeRabbit
Chores
New Features