-
-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update meetings.json and newsrooom_videos.json #3873
chore: update meetings.json and newsrooom_videos.json #3873
Conversation
WalkthroughThis pull request updates several JSON configuration files. A new meeting entry for the AsyncAPI Community Working Group Meeting on March 25, 2025, is added to Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3873 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
dashboard.json (1)
162-176
: Verify Existence of Proposal EntryThe entry "Proposal to add a 'version' value into the message object to support a more granular versioning" appears in the hotDiscussions list. However, the PR objectives mention the removal of an outdated proposal. Please review and confirm whether this entry should remain or be removed.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
config/meetings.json
(1 hunks)config/newsroom_videos.json
(2 hunks)dashboard.json
(2 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (5)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Automerge PR autoapproved by a bot
- GitHub Check: Lighthouse CI
🔇 Additional comments (7)
config/meetings.json (1)
71-78
: New Meeting Entry Added as ExpectedThe newly added "AsyncAPI Community Working Group Meeting" entry for March 25, 2025 is well-formed with all required fields (title, calLink, url, banner, date). Please double-check that the calendar link and GitHub issue URL are correct and align with the intended event.
config/newsroom_videos.json (2)
2-7
: New Video Entry AdditionThe new video entry "AsyncAPI Community Working Group Meeting, March 11th 2025" has been added with the appropriate image URL, title, description, and videoId. Ensure the description URL ("asyncapi/community#1754.") accurately reflects the issue reference.
27-30
: Updated Video Entry ReplacementThe existing video entry has been replaced with updated details for "Event-Driven and OpenTelemetry with Eduardo". The new image URL, title, description, and videoId appear correct. Please confirm these changes reflect the intended event update.
dashboard.json (4)
80-89
: Updated Score for Blog Spotlight EntryThe score for the "chore(blog): add ashmit spotlight story" entry has been updated to 14.645904026212197. Please verify that this updated metric accurately reflects the latest community engagement data.
146-160
: Converted PR to Issue for Website RedesignThe entry "Redesign the AsyncAPI Website and Implement Dark Theme" now features an updated ID, is marked as an issue (with
"isPR": false
), and includes new label details. Confirm that these changes correctly represent the current discussion status.
177-200
: Donation Entry UpdatedThe "Donation of
Neuroglia.AsyncAPI
" entry now includes updated vote labels and score. Verify that these updates accurately reflect the current data and that the vote-related details are correct.
203-217
: New Good-First-Issue Entry AddedA new bug report entry has been added detailing an issue where a YAML file is generated instead of a JSON file when using the asyncapi new file command. The provided metadata (including the resource path
/asyncapi/cli/issues/1710
) appears accurate—please confirm that all details match the observed behavior.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Bug Fixes