Skip to content

Conversation

@rogeralsing
Copy link
Contributor

Summary

  • split the final test-name segment on underscores to build deeper nodes
  • add tests covering underscore separators and path lookup
  • document TestTree splitting behavior in memory

Testing

  • dotnet test tests/Asynkron.TestRunner.Tests

Fixes #11
Related to #10

@rogeralsing
Copy link
Contributor Author

Progress update:

  • Updated TestTree to split final name segment on underscores for deeper nodes.
  • Added tests for underscore splitting and FindNodeByPath lookup.
  • Added memory note about TestTree splitting behavior.
  • Ran Determining projects to restore...
    All projects are up-to-date for restore.
    Asynkron.TestRunner.Protocol -> /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner.Protocol/bin/Debug/net10.0/Asynkron.TestRunner.Protocol.dll
    /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner.Worker/NUnitFramework.cs(100,13): warning CA1305: The behavior of 'StringBuilder.Append(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'NUnitFramework.BuildFilter(IEnumerable)' with a call to 'StringBuilder.Append(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305) [/Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner.Worker/Asynkron.TestRunner.Worker.csproj]
    /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner.Worker/NUnitFramework.cs(107,17): warning CA1305: The behavior of 'StringBuilder.Append(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'NUnitFramework.BuildFilter(IEnumerable)' with a call to 'StringBuilder.Append(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305) [/Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner.Worker/Asynkron.TestRunner.Worker.csproj]
    Asynkron.TestRunner.Worker -> /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner.Worker/bin/Debug/net10.0/testrunner-worker.dll
    /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/GitHubIssueReporter.cs(432,9): warning CA1305: The behavior of 'StringBuilder.AppendLine(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'GitHubIssueReporter.BuildIssueBody(GitHubIssueReporter.TestIssueInfo)' with a call to 'StringBuilder.AppendLine(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305) [/Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/Asynkron.TestRunner.csproj]
    /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/GitHubIssueReporter.cs(434,9): warning CA1305: The behavior of 'StringBuilder.AppendLine(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'GitHubIssueReporter.BuildIssueBody(GitHubIssueReporter.TestIssueInfo)' with a call to 'StringBuilder.AppendLine(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305) [/Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/Asynkron.TestRunner.csproj]
    /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/GitHubIssueReporter.cs(435,9): warning CA1305: The behavior of 'StringBuilder.AppendLine(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'GitHubIssueReporter.BuildIssueBody(GitHubIssueReporter.TestIssueInfo)' with a call to 'StringBuilder.AppendLine(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305) [/Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/Asynkron.TestRunner.csproj]
    /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/GitHubIssueReporter.cs(521,17): warning CA1305: The behavior of 'StringBuilder.AppendLine(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'GitHubIssueReporter.BuildIssueBody(GitHubIssueReporter.TestIssueInfo)' with a call to 'StringBuilder.AppendLine(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305) [/Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/Asynkron.TestRunner.csproj]
    /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/GitHubIssueReporter.cs(525,17): warning CA1305: The behavior of 'StringBuilder.AppendLine(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'GitHubIssueReporter.BuildIssueBody(GitHubIssueReporter.TestIssueInfo)' with a call to 'StringBuilder.AppendLine(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305) [/Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/Asynkron.TestRunner.csproj]
    /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/GitHubIssueReporter.cs(531,9): warning CA1305: The behavior of 'StringBuilder.AppendLine(ref StringBuilder.AppendInterpolatedStringHandler)' could vary based on the current user's locale settings. Replace this call in 'GitHubIssueReporter.BuildIssueBody(GitHubIssueReporter.TestIssueInfo)' with a call to 'StringBuilder.AppendLine(IFormatProvider, ref StringBuilder.AppendInterpolatedStringHandler)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305) [/Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/Asynkron.TestRunner.csproj]
    Asynkron.TestRunner -> /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/src/Asynkron.TestRunner/bin/Debug/net10.0/Asynkron.TestRunner.dll
    /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/tests/Asynkron.TestRunner.SampleXunit/ModuleInit.cs(7,6): warning CA2255: The 'ModuleInitializer' attribute is only intended to be used in application code or advanced source generator scenarios (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2255) [/Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/tests/Asynkron.TestRunner.SampleXunit/Asynkron.TestRunner.SampleXunit.csproj]
    Asynkron.TestRunner.SampleXunit -> /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/tests/Asynkron.TestRunner.SampleXunit/bin/Debug/net10.0/Asynkron.TestRunner.SampleXunit.dll
    Asynkron.TestRunner.Tests -> /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/tests/Asynkron.TestRunner.Tests/bin/Debug/net10.0/Asynkron.TestRunner.Tests.dll
    Test run for /Users/rogerjohansson/git/asynkron/Asynkron.TestRunner/.worktrees/Fix-failing-test-AddTests-underscore-splitting-https-github-com-Asynkron-asynkron-testrunner-issues-11-/tests/Asynkron.TestRunner.Tests/bin/Debug/net10.0/Asynkron.TestRunner.Tests.dll (.NETCoreApp,Version=v10.0)
    VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Passed! - Failed: 0, Passed: 59, Skipped: 0, Total: 59, Duration: 166 ms - Asynkron.TestRunner.Tests.dll (net10.0) (pass; existing CA1305/CA2255 warnings only).

@rogeralsing rogeralsing mentioned this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing Test: Asynkron.TestRunner.Tests.TestTreeTests.AddTests_TestsWithUnderscoreSeparators_SplitsCorrectly

2 participants