-
Notifications
You must be signed in to change notification settings - Fork 27
get rid of jQuery usage #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
dude the you will need jQuery anyway to run the library. |
yeah, but it uses jquery itself. It's required to get rid of it's usage or update the dependency. |
Sorry I did not have time to merge it if you fix it I can merge the change. |
@frostbolt now travis works |
@atais I'll take a look later this month. |
Hi, @atais, When I try to run them it seems like angularjs doesn't work. I can see But the most strange thing is that I've managed to run them manually running PS. I've tried to run the tests for origin/master. Unsuccessfully. |
Damn it happens from time to time because I don't update the dependencies and the tests have to be fixed. |
I have just looked into it, but it does not seem easy. To be honest, I am not working with those technologies anymore so I really do not want to step into it. If you want and could fix the tests I will gladly merge the changes. |
Hi.
Your plugin depends on outdated jQuery version, that is no longer maintained
At first I was going to move it to third jQuery but then I noticed that there's only one jQuery call that can be easily replaced with native code.
As you can see here, native
.map
realization is compatible with all modern (IE9+) browsers.