Conversation
kakra
force-pushed
the
queue/for-0.10
branch
6 times, most recently
from
a8666ca to
12f4608
Compare
kakra
force-pushed
the
queue/for-0.10
branch
4 times, most recently
from
afd33fa to
f61508f
Compare
kakra
force-pushed
the
queue/for-0.10
branch
from
e641e48 to
5f89259
Compare
kakra
force-pushed
the
queue/for-0.10
branch
9 times, most recently
from
dfc5015 to
e87d88b
Compare
kakra
force-pushed
the
queue/for-0.10
branch
5 times, most recently
from
bc8b92f to
72e6825
Compare
kakra
force-pushed
the
queue/for-0.10
branch
2 times, most recently
from
8dee9da to
a402d70
Compare
kakra
force-pushed
the
queue/for-0.10
branch
5 times, most recently
from
50e880c to
c43c047
Compare
kakra
force-pushed
the
queue/for-0.10
branch
3 times, most recently
from
52ca737 to
d599afe
Compare
kakra
force-pushed
the
queue/for-0.10
branch
5 times, most recently
from
78016e5 to
8609d1c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 20 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This will add an automatic workflow to check commit quality by using the kernel checkpatch.pl script, excluding some of the non-relevant checks because we are not inside the kernel. Signed-off-by: Kai Krakow <kai@kaishome.de>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 40 out of 41 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 40 out of 41 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* atar-axis/todo/relicensing: xpadneo, licensing: Do not chase consent from PiMaker xpadneo, licensing: Record consent from John Mather xpadneo, licensing: Record consent from yjun xpadneo, licensing: Record consent from Dugan Chen xpadneo, licensing: Record consent from Erik Hajnal xpadneo, licensing: Record consent from Ben Schattinger xpadneo, licensing: Add driver relicensing tracking document Legacy changes from monolithic `hid-xpadneo.c` were reimplemented during module split/refactor; behavior retained where needed, code structure/signatures rewritten. Some original code had already been completely replaced before this refactor and was therefore not part of the relicensing work. Closes: atar-axis#577 Closes: atar-axis#289 Signed-off-by: Kai Krakow <kai@kaishome.de>
Signed-off-by: Kai Krakow <kai@kaishome.de>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 41 out of 42 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
Makefile:74
install-metainfoinstalls xpadneo.metainfo.xml, butuninstallnever removes it. This makesmake uninstallleave files behind ifinstall-metainfo/install-allwas used. Consider removing the installed metainfo file (and cleaning up the directory if empty) or adding a dedicateduninstall-metainfotarget thatuninstall/install-allpairs with.
install-metainfo:
install -D -m 0644 -t $(PREFIX)$(META_PREFIX) xpadneo.metainfo.xml
uninstall: VERSION
$(DKMS) remove "hid-xpadneo/$(shell cat VERSION)" --all || echo "dkms: remove failed: ignored"
rm -Rf "$(PREFIX)/usr/src/hid-xpadneo-$(shell cat VERSION)"
rm -f $(DOCS:%=$(PREFIX)$(DOC_PREFIX)/%)
rm -f $(UDEV_RULES:%=$(PREFIX)$(ETC_PREFIX)/udev/rules.d/%)
rm -f $(MODPROBE_CONFS:%=$(PREFIX)$(ETC_PREFIX)/modprobe.d/%)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This prepares the release of v0.10, finalizing the license switch and updating documentation.