Skip to content

Added integrator flag (GPU), Optimized projection in acceptance boundary search #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 21, 2025
Merged

Added integrator flag (GPU), Optimized projection in acceptance boundary search #969

merged 16 commits into from
Aug 21, 2025

Conversation

@JeanLucPons
Copy link
Collaborator

@JeanLucPons JeanLucPons commented Aug 13, 2025 •
edited
Loading

  • Allow to pass integrator flag (GPU) in acceptance call to be able to select symplectic integrator to use when computing lifetime.
LTgpu,*_ = ring.get_lifetime(emity=40e-12,bunch_curr=0.2/992,use_mp=at.MPMode.GPU,refpts=refpts,grid_mode=at.GridMode.CARTESIAN,integrator=5,verbose=True)
  • Optimized projection by avoiding ring.rotate() and usage of keep_lattice=True

@JeanLucPons JeanLucPons requested a review from swhite2401 August 13, 2025 12:15
@swhite2401 swhite2401 marked this pull request as draft August 14, 2025 08:06
@JeanLucPons JeanLucPons force-pushed the add_gpu_integrator_in_acceptance branch from e3fd9ba to 97c60f3 Compare August 18, 2025 11:25
@JeanLucPons
Copy link
Collaborator Author

JeanLucPons commented Aug 18, 2025 •
edited
Loading

Enabled kwargs for get_acceptance() and get_1d_acceptance() calls rather than creating new parameters.

@JeanLucPons JeanLucPons marked this pull request as ready for review August 18, 2025 11:43
@JeanLucPons JeanLucPons changed the title Added gpu_integrator flag Added integrator flag (GPU), Optimized projection in acceptance boundary search Aug 19, 2025
swhite2401
swhite2401 reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@swhite2401 swhite2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments on my side

@swhite2401
Copy link
Contributor

swhite2401 commented Aug 20, 2025

Could you add unit test for this new feature too?
Otherwise it is all good for me

@JeanLucPons
Copy link
Collaborator Author

JeanLucPons commented Aug 20, 2025

Could you add unit test for this new feature too? Otherwise it is all good for me

Done in test_atpass.py.

@swhite2401 swhite2401 merged commit 84657e2 into master Aug 21, 2025
28 checks passed
@swhite2401 swhite2401 deleted the add_gpu_integrator_in_acceptance branch August 21, 2025 13:49
@swhite2401 swhite2401 mentioned this pull request Sep 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swhite2401 swhite2401 swhite2401 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JeanLucPons @swhite2401