Update config.guess and config.sub and enable ./autogen.sh to do so#40
Update config.guess and config.sub and enable ./autogen.sh to do so#40binki wants to merge 2 commits intoatheme:masterfrom
Conversation
To do this, it has a small automake project in autogen-automake-trap and uses automake --add-missing --copy --force to get the updated files. Then it copies them to the main source directory which uses AC_CANONICAL_HOST and AC_CANONICAL_TARGET but does not use automake.
Fixes atheme#39. Honestly, I have no idea why these files are tracked at all in the VCS. They should only exist in dist tarballs. People altering source code when working with the VCS will know to run ./autogen.sh, especially as they might need to alter configure.ac anyway.
|
I have no experience with autotools, but I wonder if it wouldn't be better to fix the buildsystem so that |
|
@grawity idk why it is this way, but libmowgli2 uses this “buildsys.mk” thing because it’s not libtool+automake. libmowgli2’s use of As I stated before, I personally don’t like how As an aside, I actually haven’t yet managed to compile libmowgli2 under MSYS2 yet. And, at the very moment, my MSYS2 dev environment is tied to a broken keyboard xD. But if I do make any headway I will try to at least post any changes I made as I suppose others might like to see it working under MSYS2. So, let me know which option you want:
|
|
I think switching to automake+libtool would be a good idea (same applies to atheme itself) since the current build system looks quite messy to me. But please let others comment on this as well. Cc: @ilbelkyr @siniStar7boy |
IMO,
config.guessandconfig.suband./configureand other things I’m forgetting about should be put in.gitignoreand only included in dist tarballs. But since atheme seems to want to include them, this is what I had to do to get./configureto run cleanly on my system. See #39.At least with this PR
./autogen.shis fixed to be smart enough to updateconfig.subandconfig.guess(which may be patched to the user’s environment, for example), so if these don’t work for others they can at least fix it themselves now instead of having to manually look for them.