-
Notifications
You must be signed in to change notification settings - Fork 159
fix(LiveChat): Remove scope assumption with LiveChat login #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(LiveChat): Remove scope assumption with LiveChat login #432
Conversation
commit: |
Breaking change is indeed an issue here but I don't think it makes much difference as scope is also defined within LiveChat console (where the app is being registered). If it's left outside it uses the default scope. |
I don't understand why you changed it to a string actually, why? |
Hey @atinux, it's been a while and I can't recall very well tbh. I had some issues trying to apply default scope and I switched to string to make it as explicit and simple as possible. LiveChat applies default scope set by the app registration screen anyway, so most people won't even set it. |
All the scopes are defined as Array of string for consistency, so I suggest we keep them like before. What do you recommend though is to make the default scope empty, and if empty, don't send the |
Could you please try locally with my latest changes and confirm it's working @mariosant ? |
This PR removes scope assumption with LiveChat login as it caused an issue when default scope would be necessary.
Also, fixes playground issues around LiveChat login.