[Fix] s3 prefix issue while downloading from ObjectStore #824
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SatabrataPaul-GitAc
requested review from
AtMrun,
firecast and
inishchith
as code owners
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 75.5%) Detailed Coverage Report |
📦 Trivy Vulnerability Scan Results
Report Summary
Scan Result Details✅ No vulnerabilities found during the scan for |
📦 Trivy Secret Scan Results
Report Summary
Scan Result Details✅ No secrets found during the scan for |
|
🛠 Docs available at: https://k.atlan.dev/application-sdk/fix-s3-path-issue |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| # os.path.commonpath or os.path.relpath can raise ValueError on Windows with different drives | ||
| # In this case, treat as user-provided path, return as-is | ||
| return path.strip("/") | ||
| return path.lstrip("/") |
There was a problem hiding this comment.
Bug: Trailing slashes no longer removed from S3 paths
Changing from strip("/") to lstrip("/") removes only leading slashes instead of both leading and trailing slashes. This breaks the documented behavior shown in the example where "datasets/sales/2024/" should return "datasets/sales/2024". Paths with trailing slashes will now be preserved, potentially causing S3 prefix mismatches where paths like "prefix/" are treated differently than "prefix".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Additional context (e.g. screenshots, logs, links)
Checklist
Copyleft License Compliance
Note
Replace strip with lstrip in get_object_store_prefix to avoid trimming trailing slashes, fixing S3 prefix handling.
get_object_store_prefixinapplication_sdk/activities/common/utils.py:path.lstrip("/")instead ofpath.strip("/")for non-temp and exception paths to preserve trailing slashes in object store prefixes.Written by Cursor Bugbot for commit 5890142. This will update automatically on new commits. Configure here.