Native: Initialize AtlaspackNative async #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dc9c912 The changes in this PR will be included in the next version bump. This PR includes changesets to release 100 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alshdavid
force-pushed
the
alsh/async-native-constructor
branch
from
65c565b to
b9fdede
Compare
alshdavid
commented
Mar 28, 2025
There was a problem hiding this comment.
This can be initialized synchronously now, no need for any channel shenanigans
alshdavid
commented
Mar 28, 2025
| @@ -66,6 +82,6 @@ export class AtlaspackV3 { | |||
| } | |||
|
|
|||
| respondToFsEvents(events: Array<Event>): boolean { | |||
| return this._internal.respondToFsEvents(events); | |||
| return atlaspackNapiRespondToFsEvents(this._atlaspack_napi, events); | |||
There was a problem hiding this comment.
Why did you opt for functions instead of adding to the _atlaspack_napi instance like before?
There was a problem hiding this comment.
napi-rs V2 has broken macros for napi classes requring us to disable macro expansion in our LSPs. This results in incorrect intelisense and limits the napi features we can use. For instance; the boilerplate in this section of code could all be handled by the macro but without macro expansion we cannot use it.
I'd like to turn macro expansion back on and to do that we either need to:
- Migrate to napi-rs v3 (which is still in alpha)
- Avoid the use of napi-rs classes (recreating them in the JS layer)
Personally, I'm okay with migrating to v3, even if it's in alpha, but I am not sure how much work is needed for the migration and if the team is comfortable with pre-release software.
alshdavid
force-pushed
the
alsh/async-native-constructor
branch
from
db6c2ee to
e5d870a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Lazy initialization of AtlaspackNapi was hiding errors occuring asynchronously. This fixes the watcher hanging, but also Matt's PR bumping the watcher version fixes it too. Por que no los dos?
Changes
Checklist