Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Deduplicate fuzzy finder keybindings #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thedaniel
Copy link
Contributor

This will require a docs update, but opening for discussion as this came up in chat with @bolinfest.

Good keybindings are precious and rare, and we don't have to hew perfectly to sublime for new users. I understand that users can rebind commands as necessary, but as most users will likely stick to the defaults, I think we should pick one binding for the fuzzy finder and stick with it. I personally remapped cmd-p to the command palette literally the first day I started using Atom so I prefer to keep cmd-t but I know that's totally subjective and could be argued into doing this the other way.

cc: @bolinfest , @atom/core

@mnquintana
Copy link
Contributor

I am extremely biased here, but I came to Atom directly from Sublime, so I favor the cmd-shift-p shortcut (although I came to Sublime from TextMate, so I was used to cmd-t before... shrugs).

@lee-dohm
Copy link
Contributor

One other data point is that the GitHub website uses the t shortcut to go to the file picker. Consistency with other GitHub products should count for something too.

@bolinfest
Copy link

Ping? Let's move this forward one way or the other to free up a keybinding!

@nathansobo
Copy link
Contributor

I'm honestly reluctant to remove either binding, but cmd-t should probably be the one to die if we really need to do it.

@mehcode
Copy link

mehcode commented Jun 1, 2015

👍 💯

The ctrl- and cmd- keybindings are a precious resource. Having two for the same package is 🐼.

However I agree that we'd need to remove cmd-t / ctrl-t

  • We have ctrl-shift-p for the command panel
  • We could have ctrl-alt-p for a project switcher (the spec runner doesn't need a keyboard shortcut as the average user doesn't care)
  • It mimics sublime in a very obvious way

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants