Skip to content

Feat: Add command input to Chart tab #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diaskabdualiev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feat: Add command input to Chart tab #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0540cf
Feat: Add command input to Chart tab
diaskabdualiev Nov 26, 2025
3c0eeb2
Fix: Log outgoing messages from Chart tab input
diaskabdualiev Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { captureElementPng, downloadDataUrlPng } from './utils/screenshot'
import PlotToolsOverlay from './components/PlotToolsOverlay'
import TabNav from './components/TabNav'
import SerialConsole from './components/SerialConsole'
import ConsoleInput from './components/ConsoleInput'
import Footer from './components/Footer'
import { exportChartData, type ChartExportOptions } from './utils/chartExport'
import { driver } from 'driver.js'
Expand Down Expand Up @@ -89,6 +90,25 @@ function App() {

const dataConnection = useDataConnection(handleIncomingLine)

const handleSendMessage = useCallback(async (message: string) => {
try {
const isControlChar = message.length === 1 && message.charCodeAt(0) < 32
const messageToSend = isControlChar ? message : (message.endsWith('\n') ? message : message + '\n')

if (isControlChar) {
const code = message.charCodeAt(0)
const ctrlName = code === 3 ? '^C (ETX)' : code === 4 ? '^D (EOT)' : `^${String.fromCharCode(64 + code)}`
consoleStore.addOutgoing(ctrlName)
} else {
consoleStore.addOutgoing(message)
}

await dataConnection.write(messageToSend)
} catch (error) {
consoleStore.addOutgoing(`Error: ${error instanceof Error ? error.message : 'Failed to send'}`, 'error')
}
}, [dataConnection, consoleStore])

const canvasRef = useRef<PlotCanvasHandle | null>(null)
const containerRef = useRef<HTMLDivElement | null>(null)
const plotContainerRef = useRef<HTMLDivElement | null>(null)
Expand Down Expand Up @@ -275,6 +295,10 @@ function App() {
onClose={() => setShowSettingsPanel(false)}
/>
</div>
<ConsoleInput
onSend={handleSendMessage}
disabled={!dataConnection.state.isConnected}
/>
</div>
) : (
<div className="flex-1 min-h-0">
Expand Down