fix(x/coredaos): missing MsgAnnotateProposal annotation length validation#307
Open
fix(x/coredaos): missing MsgAnnotateProposal annotation length validation#307
MsgAnnotateProposal annotation length validation#307Conversation
tbruyelle
requested review from
giuliostramondo,
giunatale and
jaekwon
as code owners
giunatale
reviewed
Mar 19, 2026
| ) | ||
|
|
||
| const ( | ||
| MaxAnnotationLength = 1000 |
Collaborator
There was a problem hiding this comment.
Is it enough?
I know it's simpler this way, but also maybe a constant is not ideal and should be a param instead. Just thinking out loud here, thoughts?
Collaborator
Author
There was a problem hiding this comment.
Most length limits are constants, so I did the same here. Do you think it is different for a proposal annotation ?
This reverts commit 1c4d0a9. We don't need CL entries to fix feature that has never been released.
Pantani
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix A-39